feat(settings): 编辑器主题升格为全局主题 + 主题化小改良#126
Merged
Merged
Conversation
GitHub octocat 原硬编码白色 fill，浅色主题白底上不可见。新增语义变量 --github-logo（暗色官方反白、浅色官方近黑），图标经 CSS fill 属性引用。 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
语言 / GUI 主题 / 编辑器外观属即时生效项，与整体保存事务正交，从 useSettingsDraft 抽到独立 hook：后者回归纯草稿/整体保存职责，外观自带 error 由 SettingsModal 合并展示。行为不变。 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
去掉独立的 GUI 主题项（system/light/dark），改由所选编辑器主题作为唯一 「主题」控制：主题反推浅/深写入 data-theme 驱动语义色板，并从主题色派生 整个 GUI chrome 的结构性配色（背景/前景/边框/选区，带对比度地板）。 - 主题选项加 mode 标注浅/深/auto；auto 跟随系统（深→Dark Modern、浅→ Light Modern），默认 auto - 原生窗口 themeSource 由主题反推；移除 appearance.theme 与 config:setTheme - 设置页「主题」分区改为全局主题选择器，编辑器分区只留字体/字号 - 保留浅/深语义色板（语义色仍随 data-theme 切换） - i18n 四语言同步 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概述
把「编辑器主题」升格为全局唯一的「主题」控制，整个 GUI chrome 跟随主题派生配色；并附带两项主题化相关小改良。关联 milestone 主题化配置。
改动（3 个提交）
1. fix(ui)：浅色主题 GitHub logo 改用近黑
GitHub octocat 原硬编码白色 fill，浅色主题白底上不可见。新增语义变量
--github-logo（暗色官方反白、浅色官方近黑），图标经 CSS fill 属性引用。2. refactor(settings)：外观类即时生效设置拆出 useAppearanceDraft
语言 / 主题 / 编辑器外观属即时生效项，与整体保存事务正交，从
useSettingsDraft抽到独立 hook：后者回归纯草稿/整体保存职责。行为不变。3. feat(settings)：编辑器主题升格为全局主题，GUI chrome 跟随主题派生
data-theme驱动保留的浅/深语义色板；并从主题色派生整个 GUI chrome 的结构性配色（背景/前景/边框/选区，带对比度地板防低对比主题击穿可读性）mode标注浅/深/auto；auto跟随系统（深→Dark Modern、浅→Light Modern），默认 autothemeSource由主题反推；移除appearance.theme与config:setThemeIPC验证
@meebox/repo-mirror既有 git 环境失败（已 stash 验证基线一致，与本次无关）🤖 Generated with Claude Code