Skip to content

logs for create task #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dexhorthy wants to merge 1 commit into from
Closed

logs for create task #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion acp/config/localdev/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@ patches:
images:
- name: controller
newName: controller
newTag: "202504181049"
newTag: "202505121438"
18 changes: 17 additions & 1 deletion acp/internal/server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,19 @@ func (s *APIServer) createTask(c *gin.Context) {

var req CreateTaskRequest
if err := c.ShouldBindJSON(&req); err != nil {
logger.Error(err, "Failed to bind request body")
c.JSON(http.StatusBadRequest, gin.H{"error": "Invalid request body: " + err.Error()})
return
}

logger.Info("Received task creation request",
"agentName", req.AgentName,
"namespace", req.Namespace,
"hasUserMessage", req.UserMessage != "",
"contextWindowSize", len(req.ContextWindow))

if req.AgentName == "" {
logger.Error(nil, "Missing required field: agentName")
Copy link
Copy Markdown
Contributor

@ellipsis-dev ellipsis-dev bot May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider providing a non-nil error (e.g. errors.New(...)) to logger.Error for the missing agentName case to maintain consistent error context.

Suggested change
logger.Error(nil, "Missing required field: agentName")
logger.Error(errors.New("agentName is required"), "Missing required field: agentName")

c.JSON(http.StatusBadRequest, gin.H{"error": "agentName is required"})
return
}
Expand Down Expand Up @@ -192,6 +200,7 @@ func (s *APIServer) createTask(c *gin.Context) {

// Generate (mostly) unique task name
generatedName := req.AgentName + "-task-" + uuid.New().String()[:8]
logger.Info("Generated task name", "name", generatedName)

task := &acp.Task{
ObjectMeta: metav1.ObjectMeta{
Expand All @@ -211,13 +220,20 @@ func (s *APIServer) createTask(c *gin.Context) {
if err := s.client.Create(ctx, task); err != nil {
if statusErr := new(apierrors.StatusError); errors.As(err, &statusErr) {
status := statusErr.Status()
logger.Error(err, "Failed to create task - status error",
"code", status.Code,
"message", status.Message)
c.JSON(int(status.Code), gin.H{"error": status.Message})
} else {
logger.Error(err, "Failed to create task")
logger.Error(err, "Failed to create task - unexpected error")
c.JSON(http.StatusInternalServerError, gin.H{"error": "Failed to create task: " + err.Error()})
}
return
}

logger.Info("Successfully created task",
"name", generatedName,
"namespace", namespace,
"agent", req.AgentName)
c.JSON(http.StatusCreated, task)
}