Skip to content

agent creation api #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allisoneer merged 4 commits into from
May 14, 2025
Merged

agent creation api #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c34c92
lfg we have agent creation api
allisoneer May 14, 2025
5acff58
formatting
allisoneer May 14, 2025
79cc966
fix model name mismatch type in test
allisoneer May 14, 2025
c03899a
fix tests to be happy
allisoneer May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion acp/config/localdev/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@ patches:
images:
- name: controller
newName: controller
newTag: "202505121745"
newTag: "202505141236"
24 changes: 21 additions & 3 deletions acp/internal/controller/task/send_response_url_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,13 @@ var _ = Describe("ResponseURL Functionality", func() {

// Test sending result
testMsg := "This is the final task result"
err := reconciler.sendFinalResultToResponseURL(ctx, server.URL, testMsg)
testTask := &acp.Task{
Spec: acp.TaskSpec{
ResponseURL: server.URL,
AgentRef: acp.LocalObjectReference{Name: "test-agent"},
},
}
err := reconciler.sendFinalResultToResponseURL(ctx, testTask, testMsg)
Expect(err).NotTo(HaveOccurred())

// Wait for the request to be processed with a timeout
Expand Down Expand Up @@ -106,7 +112,13 @@ var _ = Describe("ResponseURL Functionality", func() {
reconciler, ctx := initTestReconciler()

// Test sending result
err := reconciler.sendFinalResultToResponseURL(ctx, server.URL, "test message")
testTask := &acp.Task{
Spec: acp.TaskSpec{
ResponseURL: server.URL,
AgentRef: acp.LocalObjectReference{Name: "test-agent"},
},
}
err := reconciler.sendFinalResultToResponseURL(ctx, testTask, "test message")

// Should return an error due to non-200 response
Expect(err).To(HaveOccurred())
Expand All @@ -118,7 +130,13 @@ var _ = Describe("ResponseURL Functionality", func() {
reconciler, ctx := initTestReconciler()

// Use an invalid URL to cause a connection error
err := reconciler.sendFinalResultToResponseURL(ctx, "http://localhost:1", "test message")
testTask := &acp.Task{
Spec: acp.TaskSpec{
ResponseURL: "http://localhost:1",
AgentRef: acp.LocalObjectReference{Name: "test-agent"},
},
}
err := reconciler.sendFinalResultToResponseURL(ctx, testTask, "test message")

// Should return an error due to connection failure
Expect(err).To(HaveOccurred())
Expand Down
Loading
Loading