feat trim svc #62
Merged
feat trim svc #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KevRiver
commented
Nov 13, 2025
KevRiver
commented
- feat(proto): define trim svc and enum TrimTarget
- generated
KevRiver
force-pushed
the
feat-trim-svc
branch
from
ad1145f to
2894b35
Compare
KevRiver
commented
Nov 13, 2025
KevRiver
commented
Nov 13, 2025
KevRiver
force-pushed
the
feat-trim-svc
branch
from
2894b35 to
12a2723
Compare
KevRiver
force-pushed
the
feat-trim-svc
branch
from
12a2723 to
8931073
Compare
KevRiver
force-pushed
the
feat-trim-svc
branch
from
8931073 to
1214496
Compare
KevRiver
commented
Nov 21, 2025
Comment on lines
+31
to
+51
| message TrimRequest { | ||
| message BySize { | ||
| optional uint64 log_size = 1; | ||
| optional uint64 span_size = 2; | ||
| optional uint64 metric_size = 3; | ||
| } | ||
| message ByTime { | ||
| optional google.protobuf.Timestamp oldest_log = 1; | ||
| optional google.protobuf.Timestamp oldest_span = 2; | ||
| optional google.protobuf.Timestamp oldest_metric = 3; | ||
| } | ||
| int64 environment_id = 1; | ||
| oneof by { | ||
| BySize size = 2; | ||
| ByTime time = 3; | ||
| } | ||
| } | ||
|
|
||
| message TrimResponse { | ||
| uint64 trimmed = 1; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@aybabtme add Trim rpc in EnvironmentService
KevRiver
force-pushed
the
feat-trim-svc
branch
from
a961782 to
386ed78
Compare
aybabtme
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.