Fix top post widget#11
Open
zloymalefic wants to merge 6 commits into
Open
Conversation
joehoyle
requested changes
Dec 29, 2016
| * | ||
| * @return bool | ||
| */ | ||
| function hmtp_is_network_activated() { |
Member
There was a problem hiding this comment.
Given we are in a PHP namespace I don't think we need a prefix?
| public function delete_option( $option_name ) { | ||
| delete_option( $option_name ); | ||
| } | ||
| } No newline at end of file |
Member
|
Looks pretty good to me, just a couple of notes. |
Member
|
@roborourke are you happy with this? Would you be able to give it a quick test, I'm happy to merge form the code review. |
joehoyle
approved these changes
Jan 2, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@joehoyle @roborourke I've made some changes to the Rob's multisite top list version according to task
Please take a look