Skip to content

fix: support Vulkan SDK 1.4.313.0+ on Windows using silent installer #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hollykbuck wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: support Vulkan SDK 1.4.313.0+ on Windows using silent installer #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c13254
use silent install instead of 7x x
hollykbuck May 10, 2026
c965101
fix build
hollykbuck May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ jobs:
version: ${{ fromJSON(github.event.inputs.versions)[0] }}
cache: false
- name: Setup tmate session
if: steps.composite.outcome != 'success' || ${{ contains(github.event.inputs.extra_tests, 'tmate-after') }}
if: steps.composite.outcome != 'success' || contains(github.event.inputs.extra_tests, 'tmate-after')
uses: mxschmitt/action-tmate@v3.9
with:
limit-access-to-actor: true
Expand Down
20 changes: 18 additions & 2 deletions vulkan_prebuilt_helpers.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,16 @@ function _os_filename() {
esac
}

function _version_ge() {
local IFS=.
local i v1=($1) v2=($2)
for ((i=0; i<${#v1[@]} || i<${#v2[@]}; i++)); do
if (( ${v1[i]:-0} > ${v2[i]:-0} )); then return 0; fi
if (( ${v1[i]:-0} < ${v2[i]:-0} )); then return 1; fi
done
return 0
}

function download_vulkan_installer() {
local os=$1
local filename=$(_os_filename $os)
Expand Down Expand Up @@ -46,8 +56,14 @@ function install_linux() {
}

function install_windows() {
test -d $VULKAN_SDK && test -f vulkan_sdk.exe
7z x vulkan_sdk.exe -aoa -o$VULKAN_SDK
test -d "$VULKAN_SDK" && test -f vulkan_sdk.exe
if _version_ge "$VULKAN_SDK_VERSION" "1.4.313.0" ; then
echo "installing via installer command-line (version >= 1.4.313.0)" >&2
./vulkan_sdk.exe --root "$VULKAN_SDK" --accept-licenses --default-answer --confirm-command install
else
echo "installing via 7z extraction (version < 1.4.313.0)" >&2
7z x vulkan_sdk.exe -aoa -o"$VULKAN_SDK"
fi
}

function install_mac() {
Expand Down