Skip to content

feat / organize pool templates by network instead of connector#630

Merged
fengtality merged 3 commits into
developmentfrom
feat/pools-network-organization
May 11, 2026
Merged

feat / organize pool templates by network instead of connector#630
fengtality merged 3 commits into
developmentfrom
feat/pools-network-organization

Conversation

@fengtality

@fengtality fengtality commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Organize pool templates by network instead of connector
  • Standardize fetch-pools schema across Meteora and Orca connectors
  • Remove isVerified field from pool responses (APIs don't reliably return this)
  • Fix Orca getPools test to match new method signature

Related PRs

Test plan

  • All Gateway tests pass (98 suites, 912 tests)
  • Manual testing with Meteora and Orca pool listing

🤖 Generated with Claude Code

- Restructure pool templates from `pools/{connector}.json` to `pools/{chain}/{network}.json`
- Change pool list/get API to use chain+network as primary keys, connector becomes optional filter
- Add chain field to pool add/remove requests
- Make baseSymbol/quoteSymbol optional in add request (auto-fetched from pool info)
- Update pool-service to handle new directory structure
- Remove deprecated per-connector template files

This enables better organization of pools by network, allowing users to see
all pools on a network regardless of which DEX they belong to.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Update Meteora to use new API (dlmm.datapi.meteora.ag/pools)
- Add Orca fetch-pools endpoint using api.orca.so/v2/solana/pools/search
- Standardize response format across both connectors
- Add FetchPoolsRequest/Response schemas in clmm-schema.ts
- Remove isVerified field (not reliably available from APIs)
- Add tests for both endpoints

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@rapcmia rapcmia moved this to Backlog in Pull Request Board Apr 29, 2026
@rapcmia rapcmia added this to the v2.15 milestone Apr 29, 2026
@rapcmia rapcmia requested review from nikspz and rapcmia May 6, 2026 02:52
@rapcmia rapcmia moved this from Backlog to Under Review in Pull Request Board May 6, 2026
@rapcmia rapcmia changed the title feat(pools): organize pool templates by network instead of connector feat / organize pool templates by network instead of connector May 11, 2026

@rapcmia rapcmia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tested Meteora and Orca CLMM routes on Gateway.
  • Verified the full flow works: open-position -> position-info -> positions-owned -> collect-fees -> close-position.
  • On Meteora, I tested SOL-USDC and successfully opened a real position, confirmed it through both lookup routes, collected fees after a short wait, and closed it successfully.
  • On Orca, I tested PYUSD-USDC using pool 9tXiuRRw7kbejLhZXtxDxYs2REe43uH2e7k1kocgdM9B and completed the same full lifecycle successfully.
  • There were confirmation delays/timeouts during some close/position steps, but retries completed the tasks as expected on the current RPC setup.

@fengtality fengtality merged commit 970a8de into development May 11, 2026
5 checks passed
@fengtality fengtality deleted the feat/pools-network-organization branch May 11, 2026 21:19
@rapcmia rapcmia moved this from Under Review to Development 2.15.0 in Pull Request Board May 12, 2026
@rapcmia rapcmia removed the request for review from nikspz May 15, 2026 03:48
@rapcmia rapcmia moved this from Development 2.15.0 to Release v2.15.0 in Pull Request Board Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Release v2.15.0

Development

Successfully merging this pull request may close these issues.

3 participants