Fix broken footer doc links (argus.huntridgelabs.com/docs/*.md 404s)#3
Open
Fix broken footer doc links (argus.huntridgelabs.com/docs/*.md 404s)#3
Conversation
The footer used relative hrefs like `docs/failure-control.md` and `CHANGELOG.md` that resolve against argus.huntridgelabs.com, but the website doesn't host those files — they live in huntridge-labs/argus. All 13 affected links now point to the corresponding GitHub blob/tree URLs on main. Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
Previously the deploy workflow ran only `npm run build` and pushed the output straight to Pages. Type errors and broken relative href values (like the footer docs links fixed in #3) could only be caught in production. - Add `typecheck` script (`tsc --noEmit`) and `typescript` + `@types/*` dev deps. - Split workflow into `verify` (runs on push + PR) and `deploy` (runs only on push to main). Deploy now depends on verify passing. - verify runs: npm ci → typecheck → href sanity check → build. - The href check greps src/ for any `href="..."` whose value doesn't start with http(s):, mailto:, tel:, #, or /. This catches the exact class of bug where a relative path like "docs/foo.md" was shipped to a site that doesn't host those files. Note: lychee/link-checkers weren't appropriate here — the site is a Vite SPA, so hrefs live in the JS bundle, not in the built HTML. Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
3 tasks
Add CI: typecheck + relative-href sanity check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/failure-control.md,CHANGELOG.md,SECURITY.md) that resolved againstargus.huntridgelabs.comand 404'd — the website doesn't host any of those files.main(blob URLs for files, tree URL fordocs/examples/).Test plan
argus.huntridgelabs.com🤖 Generated with Claude Code