feat(ptodsl): redesign tileop simt/simd/cube subkernel surface#867
Draft
jimmychou0 wants to merge 3 commits into
Draft
feat(ptodsl): redesign tileop simt/simd/cube subkernel surface#867jimmychou0 wants to merge 3 commits into
jimmychou0 wants to merge 3 commits into
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
cef0751 to
fab48f5
Compare
6c5286b to
db7b13d
Compare
db7b13d to
7c39285
Compare
Zhendong404
suggested changes
Jun 27, 2026
| } | ||
|
|
||
| def PTOMaterializeTileOpSections | ||
| : Pass<"pto-materialize-tileop-sections", "func::FuncOp"> { |
Contributor
There was a problem hiding this comment.
NormalizeUncoveredTileSections pass和这个pass是相同功能,建议直接在NormalizeUncoveredTileSections中加逻辑处理
Zhendong404
suggested changes
Jun 27, 2026
| - **helper 内禁止 `alloc_tile`/`reserve_buffer`/`TAlloc`/任何需 PlanMemory 为 callee-local 规划的 op;内部 tile buffer 必须来自 caller operand。内部 vreg/mask/scalar 临时可存但不跨边界。** | ||
| - body 允许 tload/tstore、vector ops、scalar(PIPE_S) ops、cube ops、`pipe_barrier` 同步。 | ||
| - 不允许 host tensor/TensorSpec/vreg/mask/pipe_handle 跨边界;不允许 SIMT-only op。 | ||
| - **tileop 不能在另一 tileop/section 内调用**(避免 inline 后嵌套 section,`VPTOSplitCVModule:113-118` 禁嵌套 section)。 |
Contributor
There was a problem hiding this comment.
这里感觉可以在inline时做特殊处理,或者让VPTOSplitCVModule适配下,按理说同类section嵌套也是合理的
Codex Review该评论由 review 机器人自动更新。
SummaryReview failed at stage Findings未生成结构化 findings,因为 review 过程提前失败。 Log Tail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tileop/simd/cubesubkernel surface so decorated helpers stay naked tileop helpers while inline scopes preserve explicit vector/cube sectionsValidation
ninja -C build-local-vpto check-ptopython -m unittest discover -s ptodsl/tests -p 'test_*.py'under the PTOAS build environmentninja -C build-local-vpto check-dslRefs #859