docs: draft fixpipe tpipe design by HecreReed · Pull Request #883 · hw-native-sys/PTOAS

HecreReed · 2026-06-30T06:20:40Z

Summary

add a design draft for tpipe support of fixpipe-style TPUSH
document why PTOAS should model fixpipe config per pipe instead of per tpush
scope the first implementation cut to C2V + Acc producer + no-split, with vector quant included

Notes

docs-only change, no code changes in this PR
the draft compares current pto-isa TPUSH/TPOP/FixpipeParams semantics with PTOAS frontend pipe IR
the design recommends lowering pipe-level config into TPUSH<Pipe, TileProd, TConfig> during EmitC

gemini-code-assist · 2026-06-30T06:21:24Z

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

reedhecre · 2026-06-30T06:25:28Z

Codex Review

该评论由 review 机器人自动更新。

PR: docs: draft fixpipe tpipe design #883 docs: draft fixpipe tpipe design
Author: HecreReed
Base/Head: main / codex/fixpipe-tpipe-design-draft
Head SHA: 38fc985b9596
Trigger: PR 有新提交
Generated At: 2026-07-01T14:30:51Z
Previous Head SHA: 8946c63834a0
Status: failed at codex-review (exit=1)

Summary

Review failed at stage codex-review: exit=1

Findings

未生成结构化 findings，因为 review 过程提前失败。

Log Tail


===== STAGE clone @ 2026-07-01 22:30:35 =====
set -euo pipefail
rm -rf '/tmp/ptoas-pr-review-monitor/runs/20260701_223028_pr883/repo'
git clone --branch 'main' --depth 50 'https://github.com/hw-native-sys/PTOAS.git' '/tmp/ptoas-pr-review-monitor/runs/20260701_223028_pr883/repo'
cd '/tmp/ptoas-pr-review-monitor/runs/20260701_223028_pr883/repo'
git fetch origin 'refs/pull/883/head:pr-883' --depth 50
git fetch origin 'main' --depth 50 || true
git checkout -f 'pr-883'
git rev-parse HEAD
git diff --stat 'origin/main...HEAD' || true
Cloning into '/tmp/ptoas-pr-review-monitor/runs/20260701_223028_pr883/repo'...
From https://github.com/hw-native-sys/PTOAS
 * [new ref]           refs/pull/883/head -> pr-883
From https://github.com/hw-native-sys/PTOAS
 * branch              main       -> FETCH_HEAD
Switched to branch 'pr-883'
38fc985b9596cef2780412b6473adc6875b5df40
 docs/designs/fixpipe-tpipe-design.md | 797 +++++++++++++++++++++++++++++++++++
 1 file changed, 797 insertions(+)
===== END STAGE clone rc=0 @ 2026-07-01 22:30:42 =====

===== STAGE codex-review @ 2026-07-01 22:30:42 =====
set -euo pipefail
cd '/tmp/ptoas-pr-review-monitor/runs/20260701_223028_pr883/repo'
'codex' exec -C '/tmp/ptoas-pr-review-monitor/runs/20260701_223028_pr883/repo' -s read-only -c 'model_provider="codereview"' -c 'model="gpt-5.4"' -c 'model_reasoning_effort="xhigh"' --output-schema '/tmp/ptoas-pr-review-monitor/runs/20260701_223028_pr883/review_schema.json' -o '/tmp/ptoas-pr-review-monitor/runs/20260701_223028_pr883/codex_last_message.json' --color never - < '/tmp/ptoas-pr-review-monitor/runs/20260701_223028_pr883/review_prompt.txt'
[monitor] stage timeout: 1800s
OpenAI Codex v0.115.0 (research preview)
--------
workdir: /tmp/ptoas-pr-review-monitor/runs/20260701_223028_pr883/repo
model: gpt-5.4
provider: codereview
approval: never
sandbox: read-only
reasoning effort: xhigh
reasoning summaries: none
session id: 019f1e16-dde7-7bd3-b1d4-879e738cd6e2
--------
user
你现在在审查 GitHub PR。

仓库：hw-native-sys/PTOAS
PR：#883 docs: draft fixpipe tpipe design
作者：HecreReed
base branch：origin/main
head branch：HEAD（当前已 checkout 到 PR head）

要求：
1. 只审查这个 PR 相对 origin/main 的改动，必要时可以看上下文文件。
2. 重点找真实的 correctness / regression / contract mismatch / CI / runtime / compatibility 问题。
3. 不要提纯风格建议，不要提低价值猜测。
4. 严格按优先级输出：
   - P1：高概率会导致错误结果、编译/运行失败、严重回归、发布阻断
   - P2：重要缺陷、行为回归、遗漏校验/测试、较大兼容性问题
   - P3：次要但明确可改的问题
5. 如果没有问题，summary 直接写：未检查到 PR #883 存在问题，并返回 findings=[]。
6. 如果有问题，summary 简洁概括，findings 里每条都要给出：
   - severity
   - title
   - body（说明为什么是问题，尽量具体）
   - file（尽量给相对路径）
   - line（能确定就填整数，否则 null）

建议先查看：
- git status --short
- git diff --stat origin/main...HEAD
- git diff --unified=80 origin/main...HEAD

最终输出必须严格匹配 JSON schema。

mcp startup: no servers
Reconnecting... 1/5 (unexpected status 403 Forbidden: {"code":"INSUFFICIENT_BALANCE","message":"Insufficient account balance"}, url: https://codex.0u0o.com/responses, cf-ray: a1461c37cd2bae39-LAX, request id: fa7d11e7-3382-4952-9a49-3425904dbb06)
Reconnecting... 2/5 (unexpected status 403 Forbidden: {"code":"INSUFFICIENT_BALANCE","message":"Insufficient account balance"}, url: https://codex.0u0o.com/responses, cf-ray: a1461c3b3c1c4f1a-LAX, request id: 3641f923-b92c-489e-a102-38766678880f)
Reconnecting... 3/5 (unexpected status 403 Forbidden: {"code":"INSUFFICIENT_BALANCE","message":"Insufficient account balance"}, url: https://codex.0u0o.com/responses, cf-ray: a1461c3ffd02a5f0-LAX, request id: 68b39f2b-2aea-4fec-be97-e105a4822bc8)
Reconnecting... 4/5 (unexpected status 403 Forbidden: {"code":"INSUFFICIENT_BALANCE","message":"Insufficient account balance"}, url: https://codex.0u0o.com/responses, cf-ray: a1461c47c9d1cc65-LAX, request id: 48458cf5-f9bf-45f5-9c3b-f2149a656371)
Reconnecting... 5/5 (unexpected status 403 Forbidden: {"code":"INSUFFICIENT_BALANCE","message":"Insufficient account balance"}, url: https://codex.0u0o.com/responses, cf-ray: a1461c549d172ed9-LAX, request id: f937881e-78c0-41c8-beed-85fc1ddcd431)
ERROR: unexpected status 403 Forbidden: {"code":"INSUFFICIENT_BALANCE","message":"Insufficient account balance"}, url: https://codex.0u0o.com/responses, cf-ray: a1461c6aaa63279a-LAX, request id: 86ab2d5c-010e-48ff-8164-7bfcd1c6154e
Warning: no last agent message; wrote empty content to /tmp/ptoas-pr-review-monitor/runs/20260701_223028_pr883/codex_last_message.json
===== END STAGE codex-review rc=1 @ 2026-07-01 22:30:51 =====

gemini-code-assist · 2026-07-01T02:45:17Z

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 85f7319d98

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-01T02:48:20Z

+推荐把 fixpipe 配置挂到 `initialize_pipe`：
+
+```mlir
+pto.aic_initialize_pipe {


Mirror the fixpipe contract on the consumer init

In the current frontend pipe flow, each data op resolves its id against an initialize_pipe in the same function, so a Vector-side tpop_from_aic will only see the peer function's aiv_initialize_pipe, not this Cube-side init. If the fixpipe attrs are only shown/defined on pto.aic_initialize_pipe, verifier rules that check the consumer result type/layout and any consumer lowering have no local pipe-level contract unless a new cross-function propagation path is designed. Please require the peer aiv_initialize_pipe to carry the same attrs (and verify equality), or document the cross-function lookup explicitly.

Useful? React with 👍 / 👎.

HecreReed · 2026-07-01T07:32:29Z

/run a3 rope_kv_cache

HecreReed · 2026-07-01T07:34:17Z

/run a5 rope_kv_cache

reedhecre · 2026-07-01T07:34:37Z

已接收 /run a5 rope_kv_cache，A5 板测器会处理这条请求。

进度页：http://154.9.227.233/ptoas-board-dashboard/#board-a5
当前状态：板测器空闲，这条请求会在本轮轮询启动。
指定用例：rope_kv_cache

页面会自动刷新，可以直接看当前阶段、排队情况和最近结果。

reedhecre · 2026-07-01T07:39:22Z

A5 板测成功

触发方式：manual
源码提交：abb5b4638c31
结果汇总：OK 1 / FAIL 0 / SKIP 0
日志：/root/ptoas-board-monitor-a5/logs/20260701_153506_manual_pr883.log
结果 TSV：/root/ptoas-board-monitor-a5/logs/20260701_153506_manual_pr883.tsv
手动指令：/run a5 rope_kv_cache
触发人：HecreReed
指定用例：rope_kv_cache
触发评论：docs: draft fixpipe tpipe design #883 (comment)

reedhecre · 2026-07-01T07:54:08Z

已接收 /run a3 rope_kv_cache，A3 板测器会处理这条请求。

进度页：http://154.9.227.233/ptoas-board-dashboard/#board-a3
当前状态：板测器空闲，这条请求会在本轮轮询启动。
指定用例：rope_kv_cache

页面会自动刷新，可以直接看当前阶段、排队情况和最近结果。

reedhecre · 2026-07-01T07:59:48Z

A3 板测成功

触发方式：manual
源码提交：5e9fc35cd34d
结果汇总：OK 1 / FAIL 0 / SKIP 0
日志：/home/zhongxuan/ptoas-board-monitor/runtime/logs/20260701_155420_manual_pr883.log
LLVM cache：/home/zhongxuan/ptoas-board-monitor/cache/llvm-project-vpto-feature/build-shared
结果 TSV：/home/zhongxuan/ptoas-board-monitor/runtime/logs/20260701_155420_manual_pr883.tsv
手动指令：/run a3 rope_kv_cache
触发人：HecreReed
指定用例：rope_kv_cache
触发评论：docs: draft fixpipe tpipe design #883 (comment)

HecreReed force-pushed the codex/fixpipe-tpipe-design-draft branch 10 times, most recently from 57383b6 to 85f7319 Compare July 1, 2026 02:07

HecreReed marked this pull request as ready for review July 1, 2026 02:45

chatgpt-codex-connector Bot reviewed Jul 1, 2026

View reviewed changes

HecreReed force-pushed the codex/fixpipe-tpipe-design-draft branch from 85f7319 to 9a54ecb Compare July 1, 2026 03:17

HecreReed force-pushed the codex/fixpipe-tpipe-design-draft branch from 9a54ecb to 11c96f4 Compare July 1, 2026 07:48

HecreReed force-pushed the codex/fixpipe-tpipe-design-draft branch 4 times, most recently from 94b261c to 8946c63 Compare July 1, 2026 11:43

docs: draft fixpipe tpipe design

38fc985

HecreReed force-pushed the codex/fixpipe-tpipe-design-draft branch from 8946c63 to 38fc985 Compare July 1, 2026 14:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

docs: draft fixpipe tpipe design#883

docs: draft fixpipe tpipe design#883
HecreReed wants to merge 1 commit into
hw-native-sys:mainfrom
HecreReed:codex/fixpipe-tpipe-design-draft

HecreReed commented Jun 30, 2026

Uh oh!

gemini-code-assist Bot commented Jun 30, 2026

Uh oh!

reedhecre commented Jun 30, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot commented Jul 1, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jul 1, 2026

Uh oh!

Uh oh!

HecreReed commented Jul 1, 2026

Uh oh!

HecreReed commented Jul 1, 2026

Uh oh!

reedhecre commented Jul 1, 2026

Uh oh!

reedhecre commented Jul 1, 2026

Uh oh!

reedhecre commented Jul 1, 2026

Uh oh!

reedhecre commented Jul 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

HecreReed commented Jun 30, 2026

Summary

Notes

Uh oh!

gemini-code-assist Bot commented Jun 30, 2026

Uh oh!

reedhecre commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review

Summary

Findings

Log Tail

Uh oh!

gemini-code-assist Bot commented Jul 1, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

HecreReed commented Jul 1, 2026

Uh oh!

HecreReed commented Jul 1, 2026

Uh oh!

reedhecre commented Jul 1, 2026

Uh oh!

reedhecre commented Jul 1, 2026

A5 板测成功

Uh oh!

reedhecre commented Jul 1, 2026

Uh oh!

reedhecre commented Jul 1, 2026

A3 板测成功

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

reedhecre commented Jun 30, 2026 •

edited

Loading