Skip to content

Fix PyPTO sim runtime headers in CI#891

Closed
mouliangyu wants to merge 1 commit into
hw-native-sys:mainfrom
mouliangyu:codex/fix-pypto-sim-runtime-headers
Closed

Fix PyPTO sim runtime headers in CI#891
mouliangyu wants to merge 1 commit into
hw-native-sys:mainfrom
mouliangyu:codex/fix-pypto-sim-runtime-headers

Conversation

@mouliangyu

Copy link
Copy Markdown
Contributor

Summary

  • checkout PyPTO with recursive submodules in ci_sim so the runtime/simpler tree is present
  • add an early post-install header asset check for A5/A2A3 runtime.h and common tensor.h

Context

PR #889 failed in vpto-sim-validation during PyPTO smoke because rms_norm orchestration/kernel compilation could not find runtime.h and tensor.h. These headers live in PyPTO's runtime submodule and its installed simpler_setup assets.

Validation

  • git diff --check
  • parsed .github/workflows/ci_sim.yml with PyYAML
  • ran the new header-asset probe against a local PyPTO checkout with the runtime submodule initialized

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@reedhecre

reedhecre commented Jul 1, 2026

Copy link
Copy Markdown

Codex Review

该评论由 review 机器人自动更新。

  • PR: Fix PyPTO sim runtime headers in CI #891 Fix PyPTO sim runtime headers in CI
  • Author: mouliangyu
  • Base/Head: main / codex/fix-pypto-sim-runtime-headers
  • Head SHA: 96c97420659a
  • Trigger: PR 有新提交
  • Generated At: 2026-07-02T03:30:43Z
  • Previous Head SHA: c76dbd338447
  • Status: failed at codex-review (exit=1)

Summary

Review failed at stage codex-review: exit=1

Findings

未生成结构化 findings,因为 review 过程提前失败。

Log Tail


===== STAGE clone @ 2026-07-02 11:30:29 =====
set -euo pipefail
rm -rf '/tmp/ptoas-pr-review-monitor/runs/20260702_113027_pr891/repo'
git clone --branch 'main' --depth 50 'https://github.com/hw-native-sys/PTOAS.git' '/tmp/ptoas-pr-review-monitor/runs/20260702_113027_pr891/repo'
cd '/tmp/ptoas-pr-review-monitor/runs/20260702_113027_pr891/repo'
git fetch origin 'refs/pull/891/head:pr-891' --depth 50
git fetch origin 'main' --depth 50 || true
git checkout -f 'pr-891'
git rev-parse HEAD
git diff --stat 'origin/main...HEAD' || true
Cloning into '/tmp/ptoas-pr-review-monitor/runs/20260702_113027_pr891/repo'...
From https://github.com/hw-native-sys/PTOAS
 * [new ref]           refs/pull/891/head -> pr-891
From https://github.com/hw-native-sys/PTOAS
 * branch              main       -> FETCH_HEAD
Switched to branch 'pr-891'
96c97420659a4e31ffc976155312c715c7ca31dd
 .github/workflows/ci_sim.yml | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
===== END STAGE clone rc=0 @ 2026-07-02 11:30:34 =====

===== STAGE codex-review @ 2026-07-02 11:30:34 =====
set -euo pipefail
cd '/tmp/ptoas-pr-review-monitor/runs/20260702_113027_pr891/repo'
'codex' exec -C '/tmp/ptoas-pr-review-monitor/runs/20260702_113027_pr891/repo' -s read-only -c 'model_provider="codereview"' -c 'model="gpt-5.4"' -c 'model_reasoning_effort="xhigh"' --output-schema '/tmp/ptoas-pr-review-monitor/runs/20260702_113027_pr891/review_schema.json' -o '/tmp/ptoas-pr-review-monitor/runs/20260702_113027_pr891/codex_last_message.json' --color never - < '/tmp/ptoas-pr-review-monitor/runs/20260702_113027_pr891/review_prompt.txt'
[monitor] stage timeout: 1800s
OpenAI Codex v0.115.0 (research preview)
--------
workdir: /tmp/ptoas-pr-review-monitor/runs/20260702_113027_pr891/repo
model: gpt-5.4
provider: codereview
approval: never
sandbox: read-only
reasoning effort: xhigh
reasoning summaries: none
session id: 019f20e0-da18-7083-b4dd-e194f004ba68
--------
user
你现在在审查 GitHub PR。

仓库:hw-native-sys/PTOAS
PR:#891 Fix PyPTO sim runtime headers in CI
作者:mouliangyu
base branch:origin/main
head branch:HEAD(当前已 checkout 到 PR head)

要求:
1. 只审查这个 PR 相对 origin/main 的改动,必要时可以看上下文文件。
2. 重点找真实的 correctness / regression / contract mismatch / CI / runtime / compatibility 问题。
3. 不要提纯风格建议,不要提低价值猜测。
4. 严格按优先级输出:
   - P1:高概率会导致错误结果、编译/运行失败、严重回归、发布阻断
   - P2:重要缺陷、行为回归、遗漏校验/测试、较大兼容性问题
   - P3:次要但明确可改的问题
5. 如果没有问题,summary 直接写:未检查到 PR #891 存在问题,并返回 findings=[]。
6. 如果有问题,summary 简洁概括,findings 里每条都要给出:
   - severity
   - title
   - body(说明为什么是问题,尽量具体)
   - file(尽量给相对路径)
   - line(能确定就填整数,否则 null)

建议先查看:
- git status --short
- git diff --stat origin/main...HEAD
- git diff --unified=80 origin/main...HEAD

最终输出必须严格匹配 JSON schema。

mcp startup: no servers
Reconnecting... 1/5 (unexpected status 403 Forbidden: {"code":"INSUFFICIENT_BALANCE","message":"Insufficient account balance"}, url: https://codex.0u0o.com/responses, cf-ray: a14a9297ffae8486-SJC, request id: c1e66e08-6627-4da2-8cc1-138bd03b23cb)
Reconnecting... 2/5 (unexpected status 403 Forbidden: {"code":"INSUFFICIENT_BALANCE","message":"Insufficient account balance"}, url: https://codex.0u0o.com/responses, cf-ray: a14a929b7d90a102-LAX, request id: fa8baf85-1582-47d1-9198-7db3c5043554)
Reconnecting... 3/5 (unexpected status 403 Forbidden: {"code":"INSUFFICIENT_BALANCE","message":"Insufficient account balance"}, url: https://codex.0u0o.com/responses, cf-ray: a14a92a04cd3c10b-LAX, request id: 8f119ccc-22d6-47a5-80ea-2fbfc5a701e2)
Reconnecting... 4/5 (unexpected status 403 Forbidden: {"code":"INSUFFICIENT_BALANCE","message":"Insufficient account balance"}, url: https://codex.0u0o.com/responses, cf-ray: a14a92a77bf71e11-LAX, request id: 18f6f89a-924e-4c2d-bff9-838304f94781)
Reconnecting... 5/5 (unexpected status 403 Forbidden: {"code":"INSUFFICIENT_BALANCE","message":"Insufficient account balance"}, url: https://codex.0u0o.com/responses, cf-ray: a14a92b36d93cb9a-LAX, request id: b2f7a028-87a7-4e7c-b024-ee7485159cef)
ERROR: unexpected status 403 Forbidden: {"code":"INSUFFICIENT_BALANCE","message":"Insufficient account balance"}, url: https://codex.0u0o.com/responses, cf-ray: a14a92ca0c8ae678-SJC, request id: 859892a8-6cce-4b51-b06f-2a8689c225c8
Warning: no last agent message; wrote empty content to /tmp/ptoas-pr-review-monitor/runs/20260702_113027_pr891/codex_last_message.json
===== END STAGE codex-review rc=1 @ 2026-07-02 11:30:43 =====

@mouliangyu mouliangyu marked this pull request as ready for review July 2, 2026 02:37
@mouliangyu mouliangyu force-pushed the codex/fix-pypto-sim-runtime-headers branch from a74d8a0 to c76dbd3 Compare July 2, 2026 03:15
@mouliangyu mouliangyu force-pushed the codex/fix-pypto-sim-runtime-headers branch from c76dbd3 to 96c9742 Compare July 2, 2026 03:28
@mouliangyu mouliangyu closed this Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants