-
Notifications
You must be signed in to change notification settings - Fork 13
Add radix prefix cache backend #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zmnobug
wants to merge
2
commits into
hw-native-sys:main
Choose a base branch
from
zmnobug:feature/radix-kv-cache
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing Eviction Mechanism for Radix Cache
The radix cache implementation pins physical KV pages in memory by calling
retain_pages_for_cache(which incrementsref_cntand removes blocks fromself.free_queue) when prefixes are inserted. However, there is no eviction mechanism integrated into the block allocation path (allocate_blocksinKvCacheManager).As a result, once blocks are cached in the radix tree, they are never evicted, leading to block starvation and eventually causing the serving engine to hang or fail to schedule new requests.
Remedy:
In
KvCacheManager.allocate_blocks, ifself.num_free_blocks < num_blocks, trigger eviction from the radix cache by callingself.radix_cache.evict_pages(num_blocks - self.num_free_blocks)to free up enough blocks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in 107db2d.
KvCacheManager.allocate_blocks()now callsradix_cache.evict_pages()before returning allocation failure, and the scheduler allocation helper no longer short-circuits onnum_free_blocks, so radix-owned unlocked pages can be reclaimed during scheduling. Added regression coverage intest_radix_owned_pages_are_evicted_for_new_allocationsandtest_scheduler_allocation_can_evict_unlocked_radix_pages.