v0.7.1: fix 8 issues from hands-on evaluation#21
Merged
Merged
Conversation
- Client-side IPC size check before socket connect (prevents broken pipe on >64KB payloads) - Promote MAX_IPC_LINE_LENGTH to pub const in ipc::protocol (single source of truth) - config get of unset key prints '<key>: not set' to stderr (exit code 1 preserved) - Reject port 0 in config set (QUIC requires non-zero port) - Add tracing::debug! to IPC client path (makes -v useful for IPC debugging) - doctor --fix can now backup and reset corrupt config.yaml - Empty peers message shortened to 'No peers.' - request/notify help text documents payload wrapping on the wire - Update README internal constants table (MAX_IPC_LINE_LENGTH location) - Version bump to 0.7.1 Amp-Thread-ID: https://ampcode.com/threads/T-019c732b-acc2-7108-9846-5c6cb63fa276 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes 8 issues identified during v0.7 hands-on binary testing (
evaluations/hands-on-evaluation-2026-02-18-v0.7.md).Changes
config getunset key — prints<key>: not setto stderr (exit code 1 preserved, stdout stays empty for scriptability)config set port 0now fails with a clear error (QUIC requires a non-zero port)--verboseIPC logging — addstracing::debug!calls to the IPC client path (socket path, command size, event filtering)doctor --fixconfig reset — can now backup and reset corruptconfig.yaml(matches existingknown_peers.jsonpattern)requesthelp text — documents{"message":"<TEXT>"}payload wrappingnotifyhelp text — documents{"data":"<TEXT>"}/{"data":<JSON>}payload wrappingInfrastructure
MAX_IPC_LINE_LENGTHpromoted topub constinipc::protocol(single source of truth, shared by server and client)Tests added
config set port 0exit code + stderr,config getunset key stderr messageContribution Checklist
Security & Hardening
Test Quality & Coverage
Performance & Efficiency
Maintainability & Code Quality
Operational Maturity
cli_contracttests and docs/spec/help updates are includedAdversarial Robustness
Contribution Hygiene
make verifypasses (fmt + clippy + tests)Interop & Spec Drift Control
spec/MESSAGE_TYPES.mdandspec/WIRE_FORMAT.mdSelf-Assessment Score
Score: 99/100