v0.7.2: Remediate issues #22/#23, graduated verbosity, doc fixes#24
Merged
Conversation
Issue #22 — Inbound message logging: - Daemon logs every inbound message at INFO (msg_id, from, kind, payload_bytes) - DEBUG payload truncated to 256 bytes; TRACE emits full payload (R10) Issue #23 — Duplicate peer address detection and eviction: - evict_stale_at_addr now evicts ALL matching non-static peers, not just the first found (R1) - Discovered/cached peers blocked when static peer occupies address (O1) - upsert_static evicts all existing peers at the same address (O1) - axon doctor detects duplicate peer addresses in known_peers.json; --fix prunes stale entries with timestamped backup (R3, R4, R5) - doctor/checks.rs split into sub-modules to stay under 500-line limit (R2) Documentation: - Address-uniqueness invariant documented in CONTRIBUTING.md and AGENTS.md (R6) - Doctor description updated to mention peer-cache hygiene (R7) - README doctor section documents duplicate-peer check/fix (R8) Upgrade notes: - INFO log lines emitted for every inbound message - axon doctor --json output includes new duplicate_peer_addr check Amp-Thread-ID: https://ampcode.com/threads/T-019c73b4-570d-77aa-8e68-deba3fd707b9 Co-authored-by: Amp <amp@ampcode.com>
…trace) Replace boolean --verbose with count-based -v/-vv pattern and add --quiet/-q for suppressing per-message logs during high-throughput LLM relay workloads. Verbosity levels: -q warn only (no per-message INFO logs) (none) info — logs each inbound message summary -v debug — includes truncated payload previews (256 bytes) -vv trace — full untruncated payloads --quiet and -v are mutually exclusive. RUST_LOG takes precedence over all flags when set. Updated: README CLI contracts, cli_examples verbosity guide, unit tests, CLI contract test. Amp-Thread-ID: https://ampcode.com/threads/T-019c73b4-570d-77aa-8e68-deba3fd707b9 Co-authored-by: Amp <amp@ampcode.com>
… flags
F1: spec §6 doctor description now mentions peer-cache hygiene and
duplicate-address detection (aligns with README/AGENTS.md).
F2: spec §6 daemon synopsis documents -q/-v/-vv verbosity flags
and RUST_LOG precedence.
F3: AGENTS.md repo layout tree shows doctor/checks/ subdirectory.
Amp-Thread-ID: https://ampcode.com/threads/T-019c73b4-570d-77aa-8e68-deba3fd707b9
Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019c73b4-570d-77aa-8e68-deba3fd707b9 Co-authored-by: Amp <amp@ampcode.com>
- Convert flat library modules (config, discovery, identity, peer_table, peer_token) to directory modules (<name>/mod.rs) - Move all binary-only code (cli/, doctor/, examples) under app/ - Slim main.rs from 486 to 18 lines (thin delegator to app::run) - Split ipc/server.rs (498 lines) into server.rs + client_handler.rs - Extract all inline tests into separate test files - Normalize peer_table's 3 test files under tests/ subdirectory - Remove dead identity_tests.rs (was never wired) - Add 'Module structure conventions' section to CONTRIBUTING.md - Update AGENTS.md, CONTRIBUTING.md, README.md to reflect new paths Amp-Thread-ID: https://ampcode.com/threads/T-019c73e3-21a9-733e-96bb-73588f247da0 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remediation of evaluation findings from issues #22 and #23, plus a new graduated verbosity system and documentation fixes.
Issue #22 — Inbound message logging
msg_id,from,kind,payload_bytes)Issue #23 — Duplicate peer address detection and eviction
evict_stale_at_addrnow evicts all matching non-static peers, not just the first (R1)upsert_staticevicts all existing peers at the same address (O1)axon doctordetects duplicate peer addresses;--fixprunes with timestamped backup (R3–R5)doctor/checks.rssplit into sub-modules to stay under 500-line limit (R2)Graduated verbosity (
-q/-v/-vv)-q(warn) — suppresses per-message logs for high-throughput LLM relay-v(debug) — includes truncated payload previews-vv(trace) — full untruncated payloads--quietand-vare mutually exclusive;RUST_LOGtakes precedenceDocumentation
doctor/checks/split (F3)Upgrade notes
-qto suppress)axon doctor --jsonoutput includes a newduplicate_peer_addrcheckScore: 96/100