This repository was archived by the owner on Jan 28, 2020. It is now read-only.
WIP: Closes 3. LF/3 Add travis.yml without tests coverage#14
Open
danieljust wants to merge 2 commits into
Open
WIP: Closes 3. LF/3 Add travis.yml without tests coverage#14danieljust wants to merge 2 commits into
danieljust wants to merge 2 commits into
Conversation
maxmalov
suggested changes
Nov 5, 2017
| "precommit": "lint-staged", | ||
| "prepush": "npm test" | ||
| "prepush": "npm test", | ||
| "ci": "lint-staged && npm test" |
Collaborator
There was a problem hiding this comment.
Please read about lint-staged and what it is actually doing
danieljust
force-pushed
the
LF/3-setup-travis-ci
branch
from
7ffb165 to
af2ae03
Compare
maxmalov
suggested changes
Nov 18, 2017
| "prepush": "npm test" | ||
| "prepush": "npm test", | ||
| "ci": "npm run lint && npm test", | ||
| "lint": "./node_modules/.bin/eslint ./* --fix", |
Collaborator
There was a problem hiding this comment.
ESLint is already included in the ember test command
| @@ -0,0 +1,4 @@ | |||
| /* eslint-disable no-undef */ | |||
| /* eslint-disable no-console */ | |||
| const parsedJSON = require('./coverage/coverage-summary.json'); | |||
Collaborator
There was a problem hiding this comment.
You can add test-summary reporter instead of this dirty hack
| @@ -0,0 +1,3 @@ | |||
| module.exports = { | |||
| excludes: ['./app/templates/*', '*/mirage/**/*'] | |||
Collaborator
There was a problem hiding this comment.
Why did you exclude them?
| @@ -0,0 +1,10 @@ | |||
| node_modules | |||
Collaborator
There was a problem hiding this comment.
you don't need this, since ESLint is already included in the ember test command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.