Skip to content

fix(template): avoid treating table-prefixed custom elements as table tags #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smalluban merged 3 commits into from
Aug 5, 2026
+15 −1
Merged

fix(template): avoid treating table-prefixed custom elements as table tags #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b026a97
fix(template): tighten table tag detection
liweijie0812 Aug 4, 2026
7b454dc
test(template): cover table-prefixed custom elements
liweijie0812 Aug 4, 2026
f1336a6
chore: fix lint
liweijie0812 Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/template/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ function createContents(parts) {
tableMode =
tableMode ||
signature.match(
/<\s*(table|th|tr|td|thead|tbody|tfoot|caption|colgroup)([^<>]|"[^"]*"|'[^']*')*>\s*$/,
/<\s*(table|th|tr|td|thead|tbody|tfoot|caption|colgroup)(?=[\s>/])([^<>]|"[^"]*"|'[^']*')*>\s*$/,
);

signature +=
Expand Down
14 changes: 14 additions & 0 deletions test/spec/html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -839,6 +839,20 @@ describe("html:", () => {
expect(fragment.children[0].querySelectorAll("td").length).toBe(4);
});

it("should render custom elements with table tag prefix", () => {
define({ tag: "thead-element" });

const render = (value, className) => html`
<thead-element>${value}</thead-element>
<div class="${className}"></div>
`;

render("content", "test")(fragment);

expect(fragment.children[0].textContent).toBe("content");
expect(fragment.children[1].getAttribute("class")).toBe("test");
});

it("should set single expression in <tr> element", () => {
const render = html`
<table>
Expand Down
Loading