Implement support for controlling the alignment of stores and loads#122
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ambrus/api-v2 #122 +/- ##
=================================================
+ Coverage 83.42% 83.87% +0.44%
=================================================
Files 52 54 +2
Lines 1418 1445 +27
=================================================
+ Hits 1183 1212 +29
+ Misses 235 233 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Ambrus Tóth <32463042+tothambrus11@users.noreply.github.com>
| setOrdering(.release, for: .init(uncheckedFrom: s2.erased)) | ||
| let s3 = insertStore(pi, to: x1, at: endOf(b0)) | ||
| setOrdering(.sequentiallyConsistent, for: s3) | ||
| setOrdering(.sequentiallyConsistent, for: .init(uncheckedFrom: s3.erased)) |
Member
There was a problem hiding this comment.
The Instruction abstraction seems to be wrong. I will see how we could fix this.
Member
|
Looks good to me, except the need for the unchecked casts, which was an issue before this PR. I will make a subsequent PR that improves the abstractions, so that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.