docs(mcp): show progressive app demo#188
Conversation
📝 WalkthroughWalkthroughA new Node.js script ChangesMCP Demo Video Render Script
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request adds a script to render an SVG-based demo video for the MCP server guide, registers it in package.json, and updates the video source in the documentation. The review feedback suggests improving the script's cross-platform compatibility by adding a macOS platform check (since it relies on the macOS-only sips utility), using fileURLToPath for safe path resolution, and using execSync instead of execFileSync with a shell option for safer command verification.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Code Review
This pull request introduces a script to render an MCP demo video from SVG frames using sips and ffmpeg, registers it in package.json, and updates the video source in the documentation. The reviewer feedback highlights two key improvements for the rendering script: resolving a one-frame gap in the step animation logic that causes a brief visual flicker, and capturing stderr from the sips command to prevent swallowing error messages and facilitate debugging.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/docs/scripts/render-mcp-demo-video.mjs (1)
523-525:⚠️ Potential issue | 🟡 MinorBind encoded FPS to the configured
fpsconstant.Line 524 hardcodes
fps=30while line 24 definesfps = 15. The video filter will resample output to 30 fps, decoupling it from the script's frame rate configuration and causing frame rate mismatches.Suggested patch
- '-vf', - 'fps=30,format=yuv420p', + '-vf', + `fps=${fps},format=yuv420p`,🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/docs/scripts/render-mcp-demo-video.mjs` around lines 523 - 525, The hardcoded fps=30 in the video filter string does not use the fps constant defined at line 24 (which is set to 15), causing a frame rate mismatch. Replace the hardcoded fps=30 value in the video filter command with a reference to the fps constant variable to ensure the output frame rate matches the script's configured frame rate setting.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@packages/docs/scripts/render-mcp-demo-video.mjs`:
- Around line 523-525: The hardcoded fps=30 in the video filter string does not
use the fps constant defined at line 24 (which is set to 15), causing a frame
rate mismatch. Replace the hardcoded fps=30 value in the video filter command
with a reference to the fps constant variable to ensure the output frame rate
matches the script's configured frame rate setting.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: cfd18331-36e4-4e73-ad7f-c6dc008c9cfb
⛔ Files ignored due to path filters (2)
packages/docs/public/docs/images/openiap-mcp-iphone-purchase.pngis excluded by!**/*.pngpackages/docs/public/docs/videos/openiap-mcp-expo-test.webmis excluded by!**/*.webm
📒 Files selected for processing (2)
packages/docs/scripts/render-mcp-demo-video.mjspackages/docs/src/pages/docs/guides/mcp-server.tsx
✅ Files skipped from review due to trivial changes (1)
- packages/docs/src/pages/docs/guides/mcp-server.tsx
Summary
Verification
bun run --filter @hyodotdev/openiap-docs render:mcp-videobun run --filter @hyodotdev/openiap-docs typecheckbun audit:docsbun run --filter @hyodotdev/openiap-docs buildbun run --filter @hyodotdev/openiap-docs lintNotes
Summary by CodeRabbit
New Features
Documentation