Skip to content

refactor(timeseriesql): shared scan module and split to_clickhouse - #110

Merged
austin-barrington merged 4 commits into
mainfrom
refactor/timeseriesql-scan-split
Aug 10, 2026
Merged

refactor(timeseriesql): shared scan module and split to_clickhouse#110
austin-barrington merged 4 commits into
mainfrom
refactor/timeseriesql-scan-split

Conversation

@austin-barrington

Copy link
Copy Markdown
Member

Summary

  • Add shared scan.rs for quote/regex/paren masking used by both the SELECT clause scanner and DDL lexer, eliminating regex/division drift between parsing paths.
  • Split monolithic to_clickhouse.rs into focused submodules (select, conditions, aggregates, materialized_view, time_bounds, etc.) with public API preserved via re-exports.
  • Fix conservative OR-aware extract_time_bounds for WITH FILL anchoring: envelope min/max only when every OR disjunct defines that side; add regression tests for partial-bound OR and split_statements paren/semicolon behavior.

Test plan

  • cargo test --lib timeseriesql:: (210 passed)
  • cargo test --test compat (215 passed)
  • cargo clippy --lib -p hyperbytedb -- -D warnings

Made with Cursor

Unify quote/regex/paren masking across SELECT and DDL paths via scan.rs,
split the monolithic ClickHouse translator into submodules, and fix
conservative OR time-bound extraction for WITH FILL anchoring.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit fb37aa6. Configure here.

Comment thread hyperbytedb/src/timeseriesql/lexer.rs Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Left a non-blocking comment: Cursor Bugbot completed with 1 unresolved finding (quoted BEGIN/END masking in statement splitting), so this is not approved. Human review is needed; no reviewer assignment tool is available in this run.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

Detect CQ block keywords via scan-aware matching so substrings inside
string literals or other masked spans do not affect begin_depth.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Left a non-blocking comment: Cursor Bugbot previously reported 1 unresolved finding (quoted BEGIN/END masking in statement splitting), and no current approving review exists, so this is not approved. Human review is needed; reviewer assignment is unavailable in this run.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Left a non-blocking comment: Cursor Bugbot’s prior finding remains unresolved (quoted BEGIN/END masking in statement splitting), and there is no current approving review, so this is not approved. Human review is needed; reviewer assignment is unavailable in this run.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: Cursor Bugbot was not present on this run, and its prior finding is resolved with no open automated findings requiring human review. No reviewers were assigned (assignment tool unavailable).

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@austin-barrington
austin-barrington merged commit 5f87223 into main Aug 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant