Closed
Conversation
Contributor
Author
EnriqueL8
reviewed
Jun 3, 2024
EnriqueL8
requested changes
Jul 8, 2024
Contributor
EnriqueL8
left a comment
EnriqueL8
left a comment
There was a problem hiding this comment.
Thanks for the contribution here
I'm torn on the force pass always being true as we won't notice if thing have broken without looking at logs but at the same time I don't want this to gate PRs into the repo
So if there is a way to be notified that it has failed on the schedule it would be good.
As part of this PR would be a great contribution if the existing URL highlighted in the description are fixed as well
EnriqueL8
reviewed
Jul 8, 2024
.github/workflows/url_checker.yml
Outdated
| file_types: .md | ||
| force_pass: true | ||
| save: results.csv | ||
| exclude_patterns: 127.0.0.1,localhost,ipfs_,ca_org,ethconnect_,dataexchange_ |
Contributor
|
I can't edit my review seems like you put in your description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed some invalid URLs in the repository. This GitHub Action will help detect these invalid URLs when opening a pull request or during a scheduled scan. I recommend setting
force_passtofalseto prevent the approval of pull requests containing invalid URLs. You can see an example here.