Skip to content

fix: prevent command injection in git-changes-commit-message tool #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
123mutouren321414 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent command injection in git-changes-commit-message tool #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
import { StdioServerTransport } from "@modelcontextprotocol/sdk/server/stdio.js";
import { z } from "zod";
import { exec } from 'child_process';
import { execFile } from "child_process";
import { promisify } from 'util';
import OpenAI from 'openai';
import * as dotenv from 'dotenv';
Expand All @@ -22,7 +22,7 @@ if (!apiKey) {

dotenv.config();

const execAsync = promisify(exec);
const execFileAsync = promisify(execFile);

// Initialize OpenAI client
const openai = new OpenAI({
Expand All @@ -41,9 +41,9 @@ async function getGitChanges(input: string) {
// Get staged and unstaged changes
const cwd = input || process.cwd();
console.log("cwd", cwd);
await execAsync(`cd ${cwd}`);
const { stdout: diffOutput } = await execAsync('git diff HEAD', { cwd });
const { stdout: statusOutput } = await execAsync('git status --porcelain', { cwd });

const { stdout: diffOutput } = await execFileAsync("git", ["diff", "HEAD"], { cwd });
const { stdout: statusOutput } = await execFileAsync("git", ["status", "--porcelain"], { cwd });

// Process the changes
const changes = {
Expand Down