Open
Conversation
github-actions
Bot
added
data
docs
tizianocitro
requested changes
Apr 23, 2026
Contributor
tizianocitro
left a comment
tizianocitro
left a comment
There was a problem hiding this comment.
I have a few comments that I think are important to consider.
I didn't check tests for now.
tizianocitro
requested changes
Apr 24, 2026
|
|
||
| from unittest.mock import patch, MagicMock | ||
|
|
||
| from hyperbench.data.hif import HIFLoader, HIFProcessor |
Contributor
There was a problem hiding this comment.
Import from hyperbench.data.
Contributor
There was a problem hiding this comment.
Check all imports in all files.
| from unittest.mock import patch, MagicMock | ||
|
|
||
| from hyperbench.data.hif import HIFLoader, HIFProcessor | ||
| import hyperbench.data.hif as hif_module |
Contributor
There was a problem hiding this comment.
Check this as I feel we should not use it this way in tests.
| with ( | ||
| patch("hyperbench.data.hif.os.path.exists", return_value=False), | ||
| patch( | ||
| "hyperbench.data.hif.requests.get", |
Contributor
There was a problem hiding this comment.
Check all network-related tests work when no internet and do not make network calls.
ddevin96
force-pushed
the
feat/hif-reformed
branch
from
b28beb5 to
4807184
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions
Description
Move hif to its own file
Checklist
make test)make lint)make typecheck)Closes #44