chore(pages): publish the canonical www bundle - #65
Merged
Merged
Conversation
The repository carries www/.well-known/ but nothing was copying it into
the Pages artifact, so /.well-known/security.txt 404s — RFC 9116
discovery, and the RSR check on www/.well-known/security.txt.
* overlay the bundle between the build and the upload: www/public/
with no-clobber (a page the SSG produced always wins) and
www/.well-known/ unconditionally
* include-hidden-files: true on the upload — without it
actions/upload-pages-artifact strips .well-known/ from the artifact
after the overlay places it, every step reports success, and the
file still 404s
Additive only: nothing the SSG produces is replaced.
Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repository carries
www/.well-known/andwww/public/, but the publisher never copied them into the Pages artifact, so/.well-known/security.txt404s.Two changes, and they have to travel together:
www/public/with no-clobber (a page the SSG produced always wins) andwww/.well-known/unconditionally.include-hidden-files: true—actions/upload-pages-artifactdefaults to stripping dot-entries (its tar runs--exclude=.[^/]*), which deletes.well-known/from the artifact after the overlay places it. Every step still reports success.Without (2) the overlay is deleted; without (1) there is nothing to delete. Verified by checking the live URL after the deploy, not by the run's status.