fix(gates): require .deed, not the deprecated .a2ml - #21
Conversation
The guard counted `.a2ml` files only, so a repo carrying just a `.deed` document was told it had no manifest at all: - find \. -name '\*\.a2ml' -not -path '\./\.git/\*' + find . -type f \( -name '*.a2ml' -o -name '*.deed' \) -not -path './.git/*' The validator already reads both grammars; the caller's predicate was the bug. Wording follows the estate's own migrated copy and `deed-ecosystem/README.adoc`: `.deed` is final, `.a2ml` is legacy and no longer authored, and the template bootstraps with `just repo-init` (so the `a2mliser init` instruction is removed). Retained `.machine_readable/*.a2ml` inputs are untouched.
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (13)
🔇 Additional comments (1)
📝 SummarySummary by CodeRabbit
WalkthroughThe dogfood gate now treats ChangesManifest compliance
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the defect, rationale, and scope, but it does not use the required Summary, Changes, RSR Quality Checklist, Testing, or Screenshots sections. It also provides no test results or checklist status.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the manifest gate, Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
What breaks today
dogfood-gate.ymlcounts.a2mlfiles and nothing else, so a repo whose only manifest is a.deeddocument gets::warning::No .a2ml manifest files found, and the summary step isskipped by the same predicate. The gate is checking for a grammar the estate has deprecated.
Authority for the new wording
deed-ecosystem/README.adoc: "The DEED format name and.deedextension are final, not A2ML."rsr-template-reposhipsrsr-template-repo_chora.deedand bootstraps withjust repo-init;the removed
a2mliser initinstruction points at neither.hyperpolymath/accessibility-everywherealready carries this exact migrated form, so this PRconverges a stale copy rather than introducing a new convention.
Deliberately not touched
.machine_readable/*.a2mland any gate reading a real retained file: their own README scopesthe rename away from "retained A2ML v1 material". Rewriting those inputs would fail gates that
currently pass.
validate-a2ml.shhook filenames and the validator's ownValidate A2ML Manifestsstep name(names, not grammars).
Part of the estate-wide .deed gate migration, 2026-09-21.