Skip to content

ci(triage): tell "no gate to triage" apart from "squabble is broken" #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 3 commits into from
Sep 21, 2026
Merged

ci(triage): tell "no gate to triage" apart from "squabble is broken" #36

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7a3e51
ci(triage): handle squabble's no-gate exit code instead of failing on it
hyperpolymath Sep 21, 2026
4af3d1d
ci(triage): re-pin squabble to the revision that emits exit 3
hyperpolymath Sep 21, 2026
5b99414
Merge branch 'main' into fix/gate-triage-no-gate
hyperpolymath Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 61 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,13 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}
# Pinned, matching this file's convention for every other external ref.
SQUABBLER_SHA: 6be52e3489783669fef29ef9228022a6439819bd
# FLOOR: this pin must be at or after hyperpolymath/cicd-squabbler#99
# (merged 2026-09-21T18:55Z as 9846169c), which is what introduced the
# distinct exit 3 the Fetch step below branches on. At any earlier
# revision "no gate" is exit 2, falls into the `*` arm, and hard-fails --
# i.e. moving this pin backwards silently reverts the fix below without
# touching it. Bump it forwards freely; never behind 9846169c.
SQUABBLER_SHA: 9846169c1dc8e549edd72fa20efc6680d324d484
SQUABBLE: /tmp/squabbler/target/release/squabble
steps:
- uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
Expand All @@ -567,19 +573,70 @@ jobs:

# `squabble fetch` and `squabble fight` both take <owner>/<repo>
# <pr-number>; the job-level gate above guarantees a PR is present.
#
# Exit codes, fixed by SHA pin so their meaning cannot drift underneath:
# 0 a gate exists and was fetched -> triage it
# 3 the base branch has no `required_status_checks` ruleset rule
# -> there is nothing to triage. A finding, not a breakage.
# * anything else is a real failure and still fails this job.
#
# Before hyperpolymath/cicd-squabbler#99 every one of those was exit 2, so
# this step could not tell "nothing to triage" from "squabble is broken".
# It went red on a legitimate non-finding, and the only alternative was to
# swallow rc=2 -- which would have muted genuine breakage along with it.
# Discriminating on the message, or inferring the state from the error
# code, would both be guesses; the producer answers it instead.
- name: Fetch the live gate for this PR
id: fetch
run: |
"$SQUABBLE" fetch "${{ github.repository }}" "${{ github.event.pull_request.number }}" > gate.json
echo "--- gate.json ---"; cat gate.json
set +e
"$SQUABBLE" fetch "${{ github.repository }}" \
"${{ github.event.pull_request.number }}" > gate.json 2> fetch.err
rc=$?
set -e
cat fetch.err >&2
case "$rc" in
0)
echo "has_gate=true" >> "$GITHUB_OUTPUT"
echo "--- gate.json ---"; cat gate.json
;;
3)
echo "has_gate=false" >> "$GITHUB_OUTPUT"
rm -f gate.json
{
echo "## Gate triage: no gate to triage"
echo
echo "\`squabble fetch\` exited 3. Base branch \`${{ github.event.pull_request.base.ref }}\`"
echo "of \`${{ github.repository }}\` carries no \`required_status_checks\` ruleset rule,"
echo "so there is no gate to squabble over and triage was skipped."
echo
echo "**This job is green because nothing was triaged, not because a gate passed.**"
echo "Merges into that branch are gated by no required status check."
echo
echo "Classic branch protection is a separate API and is not visible to this query,"
echo "so this says nothing about it."
} | tee triage-outcome.md >> "$GITHUB_STEP_SUMMARY"
echo "::warning title=No gate to triage::base branch has no required_status_checks ruleset rule -- triage skipped, nothing was verified"
;;
*)
# The redirect leaves a 0-byte gate.json even when the fetch
# failed; uploading it would look like an empty gate was fetched.
rm -f gate.json
echo "::error title=squabble fetch failed::exit $rc -- this is a real failure, not a missing gate"
exit "$rc"
;;
esac

- name: Diagnose the gate
if: steps.fetch.outputs.has_gate == 'true'
run: |
"$SQUABBLE" diagnose gate.json | tee squabble-diagnose.txt

# Propose only. `|| true` because fight exits non-zero when it has work it
# cannot legitimately land — that is a finding to report, not a build break,
# and failing here would mask the very deadlock we are trying to surface.
- name: Fight (propose only — never commits, pushes or re-runs CI)
if: steps.fetch.outputs.has_gate == 'true'
run: |
"$SQUABBLE" fight "${{ github.repository }}" "${{ github.event.pull_request.number }}" \
--repo-root . --json > squabble-fight.json || true
Expand All @@ -594,4 +651,5 @@ jobs:
gate.json
squabble-diagnose.txt
squabble-fight.json
triage-outcome.md
if-no-files-found: ignore
Loading