fix(test): repoint the frontend pin-coupling test at the setup-julia step - #41
Merged
Merged
Conversation
…step Removing the 1x1 matrix broke a second consumer of `ci.yml` that I had not looked for: `frontend/tests/unit/coupling-toolchain-pins.test.ts` matched `julia-version: ["..."]` to check the CI copy of the Julia pin against mise.toml and tool_versions.yml. With the matrix gone the match returned undefined and CI failed with `Expected: "1.12.5" / Received: undefined`. The guard was right and the fix was incomplete: two files read the Julia pin out of `ci.yml`, and only the Julia-side one was updated. `grep -rln ci.yml` finds both; the six `bench/*.jl` hits are comments. The pattern is now anchored on `julia-actions/setup-julia@<sha>` rather than on a bare `version:` key, so it cannot latch onto some other step's version and pass for the wrong reason. A missing anchor yields undefined and fails loudly rather than vacuously. Verified: bumping the literal in ci.yml fails this test (3 pass / 1 fail); frontend suite 599 pass / 0 fail; test_install_pins.jl 102 / 102. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X3hgXxWm6umMgZkjYyHnnm
|
Warning Review limit reachedNext included review available in 37 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The third and last class of `ci.yml` reader. Removing the 1x1 matrix in #40 fixed the workflow and #41 fixed the TypeScript coupling test, but five live documents still describe the julia pin as living in "the CI matrix", which no longer exists. A pin table that names a source of truth that is not there is worse than no table: the next person to bump julia goes looking for a matrix, does not find one, and has no way to tell whether the doc or the workflow is wrong. docs/reproducibility.md:26,60 the pin table and the pin web docs/compliance/standards-alignment.md:40 the single-sourcing claim docs/audit/type-system-reconnaissance.md:210 what test_install_pins.jl gates README.md:546 the CI gate summary Left alone deliberately: the nine occurrences under `docs/milestones/` and `docs/milestones/02c-cicd.md`. Those are dated records of what the workflow was at that milestone, and rewriting history to match today's shape would destroy the only evidence that the matrix ever existed -- which is exactly the evidence issue #38 turned on. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X3hgXxWm6umMgZkjYyHnnm
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Follow-up to #40, which merged while this was still in flight.
mainis red without it.Removing the 1×1 matrix in #40 broke a second consumer of
ci.ymlthat I had not looked for.frontend/tests/unit/coupling-toolchain-pins.test.tsmatchedjulia-version: ["..."]to cross-check the CI copy of the Julia pin againstmise.tomlandtool_versions.yml. With the matrix gone the match returns undefined:The guard was right; my fix was incomplete. Two files read the Julia pin out of
ci.yml, in two different languages, and I updated only the Julia one — a single-language sweep misses the other.grep -rln 'ci\.yml'finds both; the sixbench/*.jlhits are comments.The pattern is now anchored on
julia-actions/setup-julia@<sha>rather than on a bareversion:key, so it cannot latch onto some other step's version and pass for the wrong reason. A missing anchor yieldsundefinedand fails loudly rather than vacuously.Verified
ci.yml→ this test must failtest_install_pins.jlAlso worth recording from #40's run, against my own prediction:
Gate triage (cicd-squabbler)passed on the first fork-internal PR to meet a real gate that lists the triage job itself. The predicted "squabble treats its own in-progress self-context as a failing required check" defect did not occur.Third commit: the docs were the third reader.
0af84a5repoints five live documents that still described the julia pin as living in "the CI matrix". The matrix was deleted in #40, so those lines named a source of truth that no longer exists — and a pin table that points at a missing source is worse than no table, because the next person to bump julia cannot tell whether the doc or the workflow is the stale one.docs/reproducibility.md:26docs/reproducibility.md:60docs/compliance/standards-alignment.md:40docs/audit/type-system-reconnaissance.md:210test_install_pins.jlgatesREADME.md:546Deliberately not touched: the nine occurrences under
docs/milestones/and indocs/milestones/02c-cicd.md. Those are dated records of what the workflow was at each milestone. Rewriting them to match today's shape would erase the only evidence that the matrix ever existed — which is precisely the evidence #38 turned on.So
ci.ymlhad three classes of reader, not two: the workflow's own consumers (the ruleset), the tests (test_install_pins.jlin Julia,coupling-toolchain-pins.test.tsin TypeScript), and the prose. A sweep that stops at executable readers is still incomplete — nothing fails when a document goes stale, which is exactly why it stays stale.🤖 Generated with Claude Code
https://claude.ai/code/session_01X3hgXxWm6umMgZkjYyHnnm