docs(audit): refresh audit citations after main rewrite; glmGamPoi notices - #84
Merged
Merged
Conversation
main was rewritten to a new root (4c2c79e, PR #83) that shares no history with the revision this audit was written against (4a848da), and the audited code moved: Execution.jl +125/-60, estimation.jl +231/-29. ilr_basis.jl, analysis.jl, provenance.jl and bench/ilr_bases/benchmark.jl are byte-identical, so their citations are untouched. Re-verifies all 21 findings against the new tree -- the four headline ones (M3 dead clr_table, M4 redundant copies, N1 mixed healing scales, W1 is_dangerous not updated on :not_run) by reading the new code rather than trusting the old line numbers -- and re-locates every citation into the two files that moved. Also corrects the catalogue for work that landed after the audit: glmGamPoi dispersion is now a pure-Julia port (SUPPORTED_DISPERSION gains "glmgampoi"; only local/mean/pooled remain refused), so estimation.dispersion_refused no longer says "use parametric" for it. Adds three entries: the port itself, its unported spline abundance trend, and its pass-1 fallback; and records in the audit that two pure-Julia kernels now exist, which bears on question 10 without changing the gate (CI still has no verdict on any of this code). Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
arena-ai-coding-agent
Bot
requested a review
from hyperpolymath
as a code owner
September 27, 2026 04:49
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hyperpolymath
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the memory / numerical / backend / warning-boundary audit
(landed on
mainin4c2c79e). Two things happened after that audit waswritten, and this PR brings it back in line with the tree it describes:
mainwas rewritten to a new root.4a848da(the revision the auditwas written against) and
4c2c79eshare no merge base —git merge-basereturns nothing.Execution.jlmoved +125/−60 andestimation.jl+231/−29, so a large part of the audit'sfile:lineevidence no longer pointed at what it claims to.
glmGamPoidispersion landed (issue feat(analysis): Advanced zero handling — glmGamPoi dispersion, Bayesian multiplicative replacement, multiplicative replacement with delta #21) as a pure-Julia port insrc/analysis/dispersion.jl. The notice catalogue was written whenglmGamPoiwas refused along withlocal/mean/pooled.Base check
hyperpolymath/MetaManifold-WebUI:main(not the upstream parent)Changes
Re-verification (not just renumbering). All 21 findings were re-checked
against
4c2c79e. Four of the six audited files are byte-identical(
ilr_basis.jl,analysis.jl,provenance.jl,bench/ilr_bases/benchmark.jl)so their citations are untouched; every citation into the two files that moved
was re-located. The four headline findings were confirmed by reading the new
code, not by trusting the old line numbers:
clr_tablewritten, never read for valuesepsilonvslog(1/epsilon))is_dangerousnot updated when estimation is:not_runCatalogue corrections for
glmGamPoi:estimation.dispersion_refused— no longer says "useparametric" forglmgampoi; that method is now supported, and onlylocal,mean,pooledare refused by name.
estimation.dispersion_glmgampoi_port(method limitation / warning) —the dispersion estimate comes from this repository's port, not R's glmGamPoi.
estimation.dispersion_spline_refused(fatal) — the spline abundancetrend at
SPLINE_TREND_MIN_FEATURES(100) features is not ported.estimation.dispersion_pass1_fallback(data quality / warning) —features with no pass-1 fit entered the dispersion estimate at their row mean.
Audit revision note recording the rewrite, the re-verification, and that two
pure-Julia kernels now exist (
dispersion.jl,zero_replacement.jl) — whichstrengthens the answer to question 10 (reference path for a future accelerated
implementation) without changing the gate: each still needs a published
conditions document, an independent oracle and a stated parity tolerance, and
CI still has no recorded verdict on any of this code.
Engineering checklist
Required
scripts/check-spdx.shpasses (391 files; the two changed files carryCC-BY-SA-4.0)bun run check— not run: this PR touches onlydocs/, and nofrontend or Julia source changed
scripts/check-format.sh/check-lint.sh— not run: both targetsource files, not prose;
check-spdx.sh, which does cover.md, passesAs applicable
CHANGELOG.md— not updated: documentation-only, no user-visiblebehaviour change
docs/testing/coverage.md— not updated: no test coverage movedTesting
Documentation only; no code path changed. Verification performed:
git merge-base 4a848da origin/main→ no merge base (confirmed rewrite)git show 4a848da:<f>vsgit show origin/main:<f>(e.g.
mean_first_i = mean(log_col[1:i]),is_dangerous = diagnostics.is_dangerous), not on a blind offsetExecution.jl:/estimation.jl:/ilr_basis.jl:/analysis.jl:/provenance.jl:/benchmark.jl:citation in both documents points at a line that exists in the current tree
bash scripts/check-spdx.sh→ OKNote for the reviewer
CI will not report on this PR. Every
CIworkflow run since 2026-09-25 hasbeen
startup_failurewith zero jobs (gh api …/jobs→{"total_count":0});GitHub's own verdict is "This run likely failed because of a workflow file
issue." That is finding B1 of the audit and it is not addressed here — it
is owner-side, and it is the first of the preconditions for the backend work
this audit was commissioned to scope.
This branch was also force-pushed: it previously carried the original audit
commit
78da9ea, whose entire patch content was already onmain, so therebase onto
4c2c79edropped it as "patch contents already upstream". Nothingwas discarded — the content is on
mainbyte-for-byte.