Skip to content

fix(ci): unblock the source-lint gate on the newly-added test files - #88

Merged
arena-ai-coding-agent[bot] merged 1 commit into
mainfrom
arena/01a0de46-metamanifold-webui
Sep 27, 2026
Merged

arena-ai-coding-agent[bot] merged 1 commit into
mainfrom
arena/01a0de46-metamanifold-webui

Conversation

@arena-ai-coding-agent

Copy link
Copy Markdown

Follow-up to #85, which restored workflow startup. With CI alive again, the Source lint step (config/ci/lint_source.jl) produced its first verdict in two days and failed on two files it had never been able to run against — neither of them touched by #85:

  1. test/doi/fixtures.jl uses the suite aliases B/P, which are const bindings defined in tests.jl before include("fixtures.jl"). The lint check is deliberately textual and per-file, so an alias supplied by the includer is invisible to it. The three call sites (B.write_checksums!, P.prepare!, P.publish!) now go through Target.DOIBundles / Target.DOIPublications — the same bindings at runtime (tests.jl defines them from Target), legible in isolation.

  2. test/unit/test_zero_replacement.jl:215 broadcast Float64.(parse.(Float64, ...)) — the outer map is an identity (parse with a Float64 target already yields Float64), and the Float64.( spelling matches the lint's Module.member pattern over test files. Removing the outer conversion changes no value.

Validation: replayed the lint's textual checks (escaped interpolation, adjacent docstrings, bare-alias member refs, the Float64.( pattern) over both files — all clean. Julia itself isn't available in this sandbox, so the definitive gate is the CI Source lint step on this PR.

Known-red checks NOT addressed here (pre-existing, not introduced by this change): repo-hygiene tsc --noEmit (frontend, likely #83-era), the stale apt-Agda 2.6.4.3 Proofs (Agda) job inside ci.yml (proofs.yml — the real gate — is green), and the DOI contracts job.

The Source lint step (config/ci/lint_source.jl) had never run on these
two files -- CI could not start between 2026-09-25 22:19 and the
Actions allow-list fix (PR #85) -- and its first verdict found members
the per-file import check cannot resolve:

* test/doi/fixtures.jl uses the suite aliases B and P, defined as
  consts in tests.jl before include("fixtures.jl"). The lint check is
  deliberately textual and per-file, so an alias supplied by the
  includer is invisible to it. The three call sites now go through
  Target.DOIBundles / Target.DOIPublications -- the same binding at
  runtime, legible in isolation.

* test/unit/test_zero_replacement.jl broadcast Float64.(...) over
  parse.(Float64, ...), which already produces Float64: the outer
  conversion is an identity map, and the Float64.( spelling trips the
  Module.member pattern the lint runs over test files. Removing it
  changes no value.

Replayed lint_source.jl's textual checks over both files after the
change: no escaped interpolation, no adjacent docstrings, no bare
alias member refs, no Float64.( broadcast remain.

Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: cbc701da-c77a-41ac-be2a-313dd8dbaca6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@arena-ai-coding-agent
arena-ai-coding-agent Bot merged commit bb663fe into main Sep 27, 2026
5 of 6 checks passed
@arena-ai-coding-agent
arena-ai-coding-agent Bot deleted the arena/01a0de46-metamanifold-webui branch September 27, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant