fix(ci): unblock the source-lint gate on the newly-added test files - #88
Merged
arena-ai-coding-agent[bot] merged 1 commit intoSep 27, 2026
Merged
Conversation
The Source lint step (config/ci/lint_source.jl) had never run on these two files -- CI could not start between 2026-09-25 22:19 and the Actions allow-list fix (PR #85) -- and its first verdict found members the per-file import check cannot resolve: * test/doi/fixtures.jl uses the suite aliases B and P, defined as consts in tests.jl before include("fixtures.jl"). The lint check is deliberately textual and per-file, so an alias supplied by the includer is invisible to it. The three call sites now go through Target.DOIBundles / Target.DOIPublications -- the same binding at runtime, legible in isolation. * test/unit/test_zero_replacement.jl broadcast Float64.(...) over parse.(Float64, ...), which already produces Float64: the outer conversion is an identity map, and the Float64.( spelling trips the Module.member pattern the lint runs over test files. Removing it changes no value. Replayed lint_source.jl's textual checks over both files after the change: no escaped interpolation, no adjacent docstrings, no bare alias member refs, no Float64.( broadcast remain. Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
arena-ai-coding-agent
Bot
requested a review
from hyperpolymath
as a code owner
September 27, 2026 06:07
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
arena-ai-coding-agent
Bot
deleted the
arena/01a0de46-metamanifold-webui
branch
September 27, 2026 06:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #85, which restored workflow startup. With CI alive again, the Source lint step (
config/ci/lint_source.jl) produced its first verdict in two days and failed on two files it had never been able to run against — neither of them touched by #85:test/doi/fixtures.jluses the suite aliasesB/P, which areconstbindings defined intests.jlbeforeinclude("fixtures.jl"). The lint check is deliberately textual and per-file, so an alias supplied by the includer is invisible to it. The three call sites (B.write_checksums!,P.prepare!,P.publish!) now go throughTarget.DOIBundles/Target.DOIPublications— the same bindings at runtime (tests.jl defines them fromTarget), legible in isolation.test/unit/test_zero_replacement.jl:215broadcastFloat64.(parse.(Float64, ...))— the outer map is an identity (parsewith aFloat64target already yieldsFloat64), and theFloat64.(spelling matches the lint'sModule.memberpattern over test files. Removing the outer conversion changes no value.Validation: replayed the lint's textual checks (escaped interpolation, adjacent docstrings, bare-alias member refs, the
Float64.( pattern) over both files — all clean. Julia itself isn't available in this sandbox, so the definitive gate is the CI Source lint step on this PR.Known-red checks NOT addressed here (pre-existing, not introduced by this change): repo-hygiene
tsc --noEmit(frontend, likely #83-era), the stale apt-Agda 2.6.4.3Proofs (Agda)job inside ci.yml (proofs.yml — the real gate — is green), and the DOI contracts job.