fix(kyaml): make drift exemptions gate-only - #89
Merged
Merged
Conversation
Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
arena-ai-coding-agent
Bot
requested a review
from hyperpolymath
as a code owner
September 27, 2026 09:07
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hyperpolymath
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--checkonly.use-kyamlanduse-yamlnow still convert and roll back bot-owned workflow files, matching the pilot's stated scope.KYAML.Statstype and add CLI-level coverage for conversion, check exemption, and rollback.YAML.jlreader for application-consumed files; leave GitHub workflow acceptance to real Actions runs.Review focus
Please review the distinction between migration scope and canonicality-gate exemptions, and whether the semantic comparison boundary for GitHub workflow YAML is appropriate. The new audit maps upstream's defaults, mutable user overlays, generated files, serializer paths, and a staged adoption plan.
Validation
bash scripts/check-spdx.sh— passed.bash scripts/check-format.sh— passed.git diff --check— passed.CIandProofsworkflows both ended instartup_failurewith zero jobs (CI, Proofs). These runs provide no test verdict. Please diagnose the workflow-start failure and obtain an actual passing CI run before merging; this PR is not being represented as green.