Repository navigation
fix: address the CodeRabbit review leftovers from #63 (boj payload hardening, checklist + ultraplan corrections) - #64
Merged
Conversation
Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
…62) AGENTS.adoc 'CI & Solver Detection' asks CI to install at least one solver on PATH. With none installed, every solver-gated test skipped on all 9 matrix legs — including the Z3 unsat-core path fixed in #49, never exercised in CI. Ubuntu legs now apt-get install z3 (with a z3 --version execution sentinel); macos/windows legs keep the documented graceful-skip behaviour. Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
…59) TOOLING-VERSION-INTEGRITY Rule 4: a bare continue-on-error must carry a GATE DEACTIVATED record or a by-design/advisory rationale within 12 lines. This one is a by-design best-effort trigger; it now says so. The curl payload quoting was mangled (the emitted body was not valid JSON); fixed. Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
It lists index.md/api.md/examples.md/solvers.md, deleted by the md->adoc migration (#32); nothing runs Documenter (casket-pages.yml builds the site, Documenter is not a dependency), and Documenter cannot consume .adoc sources. Promote-or-delete: the dead script goes. If Documenter HTML API docs are ever wanted again, that is a new decision, not a reason to keep a broken script. Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
….adoc (#61) The strength is derived from the README (pure-Julia SMT-LIB 2 frontend, one API over Z3/CVC5/Yices/MathSAT, no FFI, graceful :unknown), not invented. With the token filled, the ledger's own agent rule applies: delete the file once no listed token remains anywhere in the tree (grep-verified; the only other hits are the validator's reject-if-contains strings and the ABI template's TYPES guidance, which are not substitution tokens). Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
Estate canon R2 (CICD-SIGNAL-DISCIPLINE, ratified 2026-09-02): actions.lock present everywhere, regenerated in the same PR as any uses: change. The template ships one; this repo never had it (noted in #48's pin notes). Generated from the merged tree's uses: set (14 workflows, 31 refs, including job-level reusable-workflow calls such as hyperpolymath/standards@81dbf2dd...), in the v0.0.2 format, and verified in both directions against standards/scripts/check-lock-sync.sh semantics (the checker declared authoritative over gh actions-lock --verify-local for job-level refs). Refs #53 Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
…laims, restore links - boj-build.yml: pass github.repository/github.ref_name through env and build the JSON with jq --arg (CWE-78 hardening; values are never interpolated into the shell). - methodology.a2ml: the no-solver path raises ErrorException at SMTContext construction; :unknown is a check-sat status. Wording corrected. - ULTRAPLAN-ISSUE-43.adoc: restore the issue/PR cross-references that lost their link targets (dangling ']'), and record the post-change green CI run 38044880793 with the Z3 install sentinel and solver-backed tests executing on the ubuntu legs. - SMTLIB-AXIOM-PARITY-CHECKLIST.adoc: the docs-build entry pointed at the retired docs/make.jl; it now names the supported casket-pages.yml site build, and notes Z3-on-ubuntu landed with #62. Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
…rena/cbd1e29d-smtlib-jl # Conflicts: # .machine_readable/bot_directives/methodology.a2ml Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
# Conflicts: # .github/workflows/boj-build.yml # ULTRAPLAN-ISSUE-43.adoc Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 43 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hyperpolymath
enabled auto-merge (squash)
October 10, 2026 10:42
hyperpolymath
disabled auto-merge
October 10, 2026 10:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #63 (merged by the owner while this branch was mid-review): the three CodeRabbit review fixes that landed on the branch after the merge snapshot (
5c0c375). PR #63'sCHANGES_REQUESTEDreview is addressed here; nothing else changes.The methodology.a2ml wording fix is not included — the owner already applied their preferred wording in
5c0c375, which is inmainvia the #63 squash.Changes
.github/workflows/boj-build.yml— CodeRabbit's Major/CWE-78 finding:github.repository/github.ref_namewere interpolated into therun:script. They now pass throughenv:and the JSON payload is built withjq --arg, so no expression expansion reaches the shell or the payload string. (Theby-design:R4 rationale from fix: [repo] boj-build.yml carries a bare continue-on-error and a malformed trigger payload (TOOLING-VERSION-INTEGRITY R4) #59 is preserved.)SMTLIB-AXIOM-PARITY-CHECKLIST.adoc— the INTEND "docs build verification (docs/make.jl)" entry pointed at the Documenter script retired in docs: [repo] Retire the stale docs/make.jl — Documenter page list points at .md files deleted by the md→adoc migration #60. It now names the supportedcasket-pages.ymlsite build, and records that Z3-on-ubuntu landed with test: [repo] Install Z3 on the ubuntu CI legs so solver-gated tests run (AGENTS.adoc CI guidance) #62 (CVC5 remains optional).ULTRAPLAN-ISSUE-43.adoc— restore the issue/PR cross-references whose link targets were lost (Triage: 9 red checks surfaced by the citation PR #41 #43, test: 12 pre-existing test failures surfaced once the package loads (get_statistics, evaluate &&/||, Z3 unsat core, declare_const) #47, standards#994, PRs fix(ci): let setup-julia pick the runner arch (macOS legs) #45/fix: make SMTLib load (math.jl swap, duplicate structs) and repin julia-runtest #48/fix: make the test suite pass (12 failures tracked by #47) #49/fix(ci): make the release workflow build, attest and publish #50/chore(release): bump to 0.2.2 #51), and record the post-change verification the review asked for: CI run38044880793withInstall Z3 (ubuntu)green (incl. thez3 --versionsentinel) andRun testsgreen on all 9 matrix legs — the solver-gated tests executed with Z3 on PATH rather than skipping.Review threads addressed
boj-build.yml:19(Major) — serialise refs via env + jq ✅methodology.a2ml:58(Minor) — no-solver wording ✅ (owner's5c0c375supersedes;SMTContextraisesErrorException,:unknownis a check-sat status)ULTRAPLAN-ISSUE-43.adoc:9(Minor) — dangling]references ✅ULTRAPLAN-ISSUE-43.adoc:372(Minor) — staledocs/make.jlreference in the parity checklist ✅ULTRAPLAN-ISSUE-43.adoc:374(Minor) — post-change green CI run with Z3 ✅Verification
{{…}}template tokens, no conflict markers,check-lock-syncstill in sync (nouses:changes in this PR).boj-build.ymlpayload construction now has no string-interpolated expressions in the shell.Refs #53 (umbrella). No issue-closing keywords here — #43 closed with #63; the remaining wave items (#56 mirror, #57 Pages) await the owner's ruling.