feat(api): phase-2 weave, aspects as data + keystore - #90
Merged
Merged
Conversation
The weave: cross-cutting concerns become aspects — data on the resolution, not code copied into every resolver. aspects.zig runs the five-step pipeline once (cache read -> produce -> envelope -> cache write -> audit); resolvers collapse to producers plus aspect lists, and REST, gRPC and GraphQL all resolve through the same pipelines. Cache hits are audited too; the temporal producer fixes a dangling slice in the as_of default-time path. Deny-by-default: keystore.zig loads keys from AERIE_API_KEYS / KYAML api_keys (key:name:modules), constant-time compared, no early exit. Missing/unknown key -> 401, unentitled module -> 403; health and meta stay public; every decision is audited. Compose sets open for dev. /api/v1/meta renders the same route and aspect tables the dispatcher uses — the description cannot drift from the behaviour. Verified live: 401/403/200 matrix, entitlement scoping, meta output, open-mode fallback. 43/43 tests. Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (13)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The weave: cross-cutting concerns become aspects — data on the resolution, not code copied into every resolver. aspects.zig runs the five-step pipeline once (cache read -> produce -> envelope -> cache write -> audit); resolvers collapse to producers plus aspect lists, and REST, gRPC and GraphQL all resolve through the same pipelines. Cache hits are audited too; the temporal producer fixes a dangling slice in the as_of default-time path.
Deny-by-default: keystore.zig loads keys from AERIE_API_KEYS / KYAML api_keys (key:name:modules), constant-time compared, no early exit. Missing/unknown key -> 401, unentitled module -> 403; health and meta stay public; every decision is audited. Compose sets open for dev.
/api/v1/meta renders the same route and aspect tables the dispatcher uses — the description cannot drift from the behaviour.
Verified live: 401/403/200 matrix, entitlement scoping, meta output, open-mode fallback. 43/43 tests.
Summary
Changes
RSR Quality Checklist
Required
just testor equivalent)just fmtor equivalent)unsafeblocks without// SAFETY:commentsbelieve_me,unsafeCoerce,Obj.magic,Admitted,sorry).envfiles includedAs Applicable
.machine_readable/descriptiles/STATE.a2mlupdated (if project state changed).machine_readable/descriptiles/ECOSYSTEM.a2mlupdated (if integrations changed).machine_readable/descriptiles/META.a2mlupdated (if architectural decisions changed)TOPOLOGY.mdupdated (if architecture changed)CHANGELOGor release notes updatedsrc/interface/abi/andsrc/interface/ffi/consistent)Testing
Screenshots