Skip to content

fix(ci): pin third-party actions to full commit SHAs - #83

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/sha-pin-actions
Sep 20, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
fix/sha-pin-actions

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

fix(ci): pin third-party actions to full commit SHAs

The account's Actions policy requires a full-length SHA ref. A tag or branch ref is refused at
startup — startup_failure, no jobs, "this workflow graph cannot be shown" — so these workflows
could not run at all. This resolves each ref to the commit it currently points at and records the
ref in a trailing comment, e.g. actions/checkout@<sha> # v4.

dtolnay/rust-toolchain takes its toolchain from the ref itself, so those steps also gained an
explicit with: toolchain: input; without it, a SHA ref would silently lose the channel.

No behaviour is intended to change beyond the pins.

@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Warning

Review limit reached

Next included review available in 34 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: ea0921c6-96fa-4a37-ac60-88387126ac49

📥 Commits

Reviewing files that changed from the base of the PR and between 2efc148 and 3ca9fef.

📒 Files selected for processing (15)
  • .github/workflows/boj-build.yml
  • .github/workflows/casket-pages.yml
  • .github/workflows/codeql.yml
  • .github/workflows/dependabot-automerge.yml
  • .github/workflows/dogfood-gate.yml
  • .github/workflows/governance.yml
  • .github/workflows/hypatia-scan.yml
  • .github/workflows/instant-sync.yml
  • .github/workflows/label-triage.yml
  • .github/workflows/labels.yml
  • .github/workflows/main-estate-audit.yml
  • .github/workflows/mirror.yml
  • .github/workflows/push-email-notify.yml
  • .github/workflows/scorecard.yml
  • .github/workflows/secret-scanner.yml

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: ba9f1d72-bf20-4c8b-a940-27251972a963

📥 Commits

Reviewing files that changed from the base of the PR and between 106ace1 and 2efc148.

📒 Files selected for processing (14)
  • .github/workflows/boj-build.yml
  • .github/workflows/casket-pages.yml
  • .github/workflows/codeql.yml
  • .github/workflows/dependabot-automerge.yml
  • .github/workflows/dogfood-gate.yml
  • .github/workflows/instant-sync.yml
  • .github/workflows/main-estate-audit.yml
  • .github/workflows/push-email-notify.yml
  • asdf-acceleration-middleware/.github/workflows/ci.yml
  • asdf-acceleration-middleware/.github/workflows/release.yml
  • asdf-acceleration-middleware/.github/workflows/rust-ci.yml
  • asdf-augmenters/asdf-acceleration-middleware/.github/workflows/ci.yml
  • asdf-augmenters/asdf-acceleration-middleware/.github/workflows/release.yml
  • asdf-augmenters/asdf-acceleration-middleware/.github/workflows/rust-ci.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (18)
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Actions lockfile verify
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: scan / shell-secrets
  • GitHub Check: scan / gitleaks
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: scan / rust-secrets

📝 Summary

Summary by CodeRabbit

  • Chores
    • Pinned GitHub Actions used by build, test, deployment, notification, security, and release workflows to immutable commit references.
    • Preserved the corresponding action versions and existing workflow logic.
    • Explicitly selected the stable Rust toolchain in applicable workflows.
    • Pinned coverage reporting and artifact-handling actions for more consistent automation.

Walkthrough

Changes

Workflow action pinning

Layer / File(s) Summary
Repository workflow pins
.github/workflows/*
Top-level workflows now use immutable commit SHAs for checkout, validation, deployment, notification, propagation, and estate-audit actions.
Middleware workflow pins
asdf-acceleration-middleware/.github/workflows/*
Middleware workflows pin Rust toolchain, Codecov, artefact, and release actions. Stable toolchain inputs are explicit where changed.
Augmenter workflow pins
asdf-augmenters/asdf-acceleration-middleware/.github/workflows/*
Augmenter workflows apply the same commit pinning to Rust toolchain, Codecov, artefact, and release actions.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Refactor

Suggested reviewers: metadatastician

Merge Risk: ⚪ Minimal · up to 2efc1

The workflow pins preserve the intended Rust toolchain behavior, and no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: pinning third-party CI actions to full commit SHAs.
Description check ✅ Passed The description directly explains the Actions policy requirement, the SHA pinning changes, the explicit Rust toolchain inputs, and the intended absence of behavioural changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks each workflow line
Fixed commits make the references align
Rust tools stand on versions clear
Pages and checks stay pinned here
The burrow builds with less surprise

Comment @coderabbitai help to get the list of available commands.

…0.1.6)

`actions.lock` is authoritative: the workflows carry readable refs and the lock records the
commit each ref resolves to, which is what actually runs. Refs that stop matching the manifest
make the whole repository unstartable — `startup_failure`, "Invalid lockfile".

Regenerated with the official extension (`github/gh-actions-lock`). The hand-pinned SHA refs are
reverted to their readable form here precisely because the lockfile, not the workflow, is what
pins them.
@@ -1,3 +1,4 @@
# This workflow is managed by gh actions-lock.
@hyperpolymath
hyperpolymath merged commit b3f4d0d into main Sep 20, 2026
27 of 32 checks passed
@hyperpolymath
hyperpolymath deleted the fix/sha-pin-actions branch September 20, 2026 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants