Skip to content

chore(ci): remove dead Codecov upload steps + lock pins - #84

Merged
hyperpolymath merged 1 commit into
mainfrom
chore/remove-dead-app-ci-refs
Sep 20, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
chore/remove-dead-app-ci-refs

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Removed CI references to apps that are no longer installed on this account/org.

Why this is a fix, not a tidy-up

  • Codecov was uninstalled as a GitHub App, but its action steps remain in workflows.
  • The estate Actions allowlist already pruned codecov/codecov-action@* (standards/config/settings/actions-allowlist.json -> pruned_from_live_2026_09_02), so a workflow still calling it fails at job start instead of quietly no-op-ing.
  • Snyk / Codacy / Mergify / ImgBot / CodeFactor are on the estate never-re-add list (standards spec §9, rulings R1/R4/R5).

Changes

  • asdf-acceleration-middleware/.github/workflows/ci.yml — applied
  • asdf-acceleration-middleware/.github/workflows/rust-ci.yml — applied
  • asdf-augmenters/asdf-acceleration-middleware/.github/workflows/ci.yml — applied
  • asdf-augmenters/asdf-acceleration-middleware/.github/workflows/rust-ci.yml — applied

Notes

  • actions.lock entries for the removed actions are deleted in this same commit (the same-PR regen rule in the CI/CD regularisation spec §6.4), so actions-lock-verify sees no drift.
  • Removals are line-exact; no other line was reformatted and no comment was re-wrapped.
  • Historical records (milestone logs, CHANGELOG, audit docs, specs) that describe the removal were deliberately left untouched.
  • The gitar-approved label is intentionally frozen per docs/LABELS.adoc — it is not an active Gitar install, so it stays.

Line-exact removal of dead-app CI references.
@coderabbitai

coderabbitai Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 91798a5c-0a8a-4179-8022-8dedaf173888

📥 Commits

Reviewing files that changed from the base of the PR and between b3f4d0d and d3fd13a.

📒 Files selected for processing (4)
  • asdf-acceleration-middleware/.github/workflows/ci.yml
  • asdf-acceleration-middleware/.github/workflows/rust-ci.yml
  • asdf-augmenters/asdf-acceleration-middleware/.github/workflows/ci.yml
  • asdf-augmenters/asdf-acceleration-middleware/.github/workflows/rust-ci.yml
💤 Files with no reviewable changes (4)
  • asdf-augmenters/asdf-acceleration-middleware/.github/workflows/ci.yml
  • asdf-acceleration-middleware/.github/workflows/ci.yml
  • asdf-acceleration-middleware/.github/workflows/rust-ci.yml
  • asdf-augmenters/asdf-acceleration-middleware/.github/workflows/rust-ci.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Coverage reports are no longer uploaded to Codecov by the CI workflows.
    • Coverage report generation remains unchanged.

Walkthrough

The PR removes Codecov upload steps from four Rust coverage workflows. Coverage generation with cargo tarpaulin remains unchanged.

Changes

Coverage workflow updates

Layer / File(s) Summary
Remove Codecov uploads
.github/workflows/ci.yml, .github/workflows/rust-ci.yml in asdf-acceleration-middleware/ and asdf-augmenters/asdf-acceleration-middleware/
The four coverage jobs no longer run codecov/codecov-action@v3 or upload cobertura.xml. Coverage generation remains in place.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: metadatastician

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main changes: removal of obsolete Codecov upload steps and lock pins from CI configuration.
Description check ✅ Passed The description is directly related to the changes. It explains why the Codecov steps and lock entries were removed and identifies the affected workflow files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the coverage trail
The Codecov upload leaves no trace
Tarpaulin still runs its course
Four workflows keep their pace
Ears up, reports stay in place

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath merged commit 483440b into main Sep 20, 2026
28 of 32 checks passed
@hyperpolymath
hyperpolymath deleted the chore/remove-dead-app-ci-refs branch September 20, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant