Skip to content

fix(ci): pin third-party actions to full commit SHAs - #83

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/sha-pin-actions
Sep 20, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
fix/sha-pin-actions

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

fix(ci): pin third-party actions to full commit SHAs

The account's Actions policy requires a full-length SHA ref. A tag or branch ref is refused at
startup — startup_failure, no jobs, "this workflow graph cannot be shown" — so these workflows
could not run at all. This resolves each ref to the commit it currently points at and records the
ref in a trailing comment, e.g. actions/checkout@<sha> # v4.

dtolnay/rust-toolchain takes its toolchain from the ref itself, so those steps also gained an
explicit with: toolchain: input; without it, a SHA ref would silently lose the channel.

No behaviour is intended to change beyond the pins.

The account's Actions policy requires a full-length SHA ref. A tag or branch ref is refused at
startup — `startup_failure`, no jobs, "this workflow graph cannot be shown" — so these workflows
could not run at all. This resolves each ref to the commit it currently points at and records the
ref in a trailing comment, e.g. `actions/checkout@<sha> # v4`.

`dtolnay/rust-toolchain` takes its toolchain from the ref itself, so those steps also gained an
explicit `with: toolchain:` input; without it, a SHA ref would silently lose the channel.

No behaviour is intended to change beyond the pins.
@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: eafcfdf4-fee5-48e1-a585-268f020566b1

📥 Commits

Reviewing files that changed from the base of the PR and between 5bd9863 and 2a5e8c6.

📒 Files selected for processing (2)
  • .github/workflows/main-estate-audit.yml
  • .github/workflows/rhodibot.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (31)
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Actions lockfile verify
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: scan / shell-secrets
  • GitHub Check: scan / gitleaks
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: scan / rust-secrets
  • GitHub Check: analyze (actions, none)
  • GitHub Check: Patch Bridge CVE triage
  • GitHub Check: panic-attack assail
  • GitHub Check: Empty-linter (invisible characters)
  • GitHub Check: Hypatia neurosymbolic scan
  • GitHub Check: Groove manifest check
  • GitHub Check: Validate A2ML manifests
  • GitHub Check: Validate eclexiaiser manifest
  • GitHub Check: estate-audit
  • GitHub Check: openssf-compliance
  • GitHub Check: estate-rules
  • GitHub Check: Validate K9 contracts
  • GitHub Check: GitGuardian Security Checks
🔇 Additional comments (2)
.github/workflows/main-estate-audit.yml (1)

13-13: LGTM!

Also applies to: 16-16, 19-19, 22-22, 25-25, 28-28, 31-31, 34-34, 37-37, 40-40, 43-43, 46-46, 49-49, 52-52, 55-55, 58-58, 61-61, 64-64, 67-67, 70-70, 73-73, 76-76, 79-79, 82-82, 85-85, 88-88, 91-91

.github/workflows/rhodibot.yml (1)

37-37: LGTM!


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated automated workflows to use immutable, commit-pinned action references.
    • Preserved existing validation, compliance checks and report-only behaviour.
    • Improved workflow reproducibility and protection against unexpected changes to third-party actions.

Walkthrough

The workflows replace mutable GitHub Actions references with immutable commit SHAs. Existing validation gates, ordering, checkout behaviour, and compliance canary logic remain unchanged.

Changes

Workflow action pinning

Layer / File(s) Summary
Pin workflow action references
.github/workflows/main-estate-audit.yml, .github/workflows/rhodibot.yml
The workflows use fixed commit SHAs for actions/checkout and cicd-suite actions. Existing workflow logic remains unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the purpose, affected behaviour, SHA pinning, version comments, and Rust toolchain change. It does not follow the required template because it omits the Summary, Changes, RSR … Add the required template sections. List the key changes, complete the required and applicable checklist items, and describe the tests or checks performed. State whether screenshots or terminal output apply.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: pinning third-party CI actions to full commit SHAs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the purpose, affected behaviour, SHA pinning, version comments, and Rust toolchain change. It does not follow the required template because it omits the Summary, Changes, RSR Quality Checklist, Testing, and Screenshots sections.

  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks each action pin
Fixed commits keep the gates within
The audit steps retain their place
The canary keeps its report-only pace
No mutable tag can change the race

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit 4abd717 into main Sep 20, 2026
34 of 39 checks passed
@hyperpolymath
hyperpolymath deleted the fix/sha-pin-actions branch September 20, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant