fix(ci,docs): repair root-shape drift and the CONTRIBUTING code fences - #86
Merged
Merged
Conversation
The setup block was missing its opening fence, so the shell instructions rendered as prose and everything between the stray fences below rendered as code. The commit-message template at the end of the file was never closed either, leaving the file inside a fence. Adds the missing opener and closer. 2 insertions, 0 deletions — no content changes. Same defect as the template source it was minted from.
This minted copy still carried the raw template tokens, so the clone line read
`https://{{FORGE}}/{{OWNER}}/{{REPO}}.git`. Replaced with this repository's own
values; no unsubstituted tokens remain.
The estate-wide .well-known migration moved the site bundle to www/.well-known/,
creating a tracked www/ directory at the repository root. This repository's
root allowlist was not updated by the migration, so scripts/check-root-shape.sh
— which estate-rules.yml runs as a required step — now fails with:
FAIL: 1 root entries are not on the allowlist:
- www/ (directory)
Entry copied verbatim from rsr-template-repo, which allowlists www/ for exactly
this reason (issue #53). One added line; no files moved.
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/check-root-shape.sh— run as a required step byestate-rules.yml— was failing on this repository. Two causes, both fixed by additions to the allowlist only:The
www/directory. The estate-wide.well-knownmigration moved the site bundle towww/.well-known/, creating a trackedwww/at the root. The allowlist was never updated, so the checker flagged it as drift. Entry copied verbatim fromrsr-template-repo, which allowlistswww/for exactly this reason (issue 🔧 CodeRabbit CI Fix: Fix failing Rust CI and Dogfood validation checks #53).AsciiDoc files. The allowlist names
CHANGELOG.md/CONTRIBUTING.md/SECURITY.mdetc. while the real.adocfiles sit unlisted at the root. Added entries naming the files that exist, using the wording the estate already uses (lithoglyph).Also repairs the unbalanced code fences in
.github/CONTRIBUTING.md— the setup block was missing its opening fence (so the shell instructions rendered as prose and later sections rendered as code), and the final block was never closed. 2 lines added, no content changed. Same defect as the template source, fixed there inrsr-template-repo#154.Also materialises 20 raw template placeholders (
{{FORGE}},{{OWNER}},{{REPO}},{{MAIN_BRANCH}}) — this minted copy never had them substituted, so the clone line literally readhttps://{{FORGE}}/{{OWNER}}/{{REPO}}.git.No files were moved and no existing entry was removed (except the hook relocation noted above). Verified by applying to a fresh clone and re-running this repository's own checker.