Skip to content

fix(ci): pin third-party actions to full commit SHAs - #69

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/sha-pin-actions
Sep 19, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
fix/sha-pin-actions

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

fix(ci): pin third-party actions to full commit SHAs

The account's Actions policy requires a full-length SHA ref. A tag or branch ref is refused at
startup — startup_failure, no jobs, "this workflow graph cannot be shown" — so these workflows
could not run at all. This resolves each ref to the commit it currently points at and records the
ref in a trailing comment, e.g. actions/checkout@<sha> # v4.

dtolnay/rust-toolchain takes its toolchain from the ref itself, so those steps also gained an
explicit with: toolchain: input; without it, a SHA ref would silently lose the channel.

No behaviour is intended to change beyond the pins.

The account's Actions policy requires a full-length SHA ref. A tag or branch ref is refused at
startup — `startup_failure`, no jobs, "this workflow graph cannot be shown" — so these workflows
could not run at all. This resolves each ref to the commit it currently points at and records the
ref in a trailing comment, e.g. `actions/checkout@<sha> # v4`.

`dtolnay/rust-toolchain` takes its toolchain from the ref itself, so those steps also gained an
explicit `with: toolchain:` input; without it, a SHA ref would silently lose the channel.

No behaviour is intended to change beyond the pins.
@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 3964a456-68b6-4f38-b967-837fdc7644d7

📥 Commits

Reviewing files that changed from the base of the PR and between 3dfb484 and 4158da4.

📒 Files selected for processing (8)
  • .github/workflows/casket-pages.yml
  • .github/workflows/codeql.yml
  • .github/workflows/dogfood-gate.yml
  • .github/workflows/hypatia-scan.yml
  • .github/workflows/instant-sync.yml
  • .github/workflows/push-email-notify.yml
  • .github/workflows/secret-scanner.yml
  • .github/workflows/workflow-linter.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (15)
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: governance / Actions lockfile verify
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: Analyze (actions)
🔇 Additional comments (8)
.github/workflows/casket-pages.yml (1)

25-25: LGTM!

Also applies to: 28-28, 34-34, 40-40, 102-102, 105-105, 118-118

.github/workflows/codeql.yml (1)

39-39: LGTM!

Also applies to: 42-42, 48-48

.github/workflows/hypatia-scan.yml (1)

51-51: LGTM!

Also applies to: 56-56, 110-110, 246-246, 386-386

.github/workflows/dogfood-gate.yml (1)

30-30: LGTM!

Also applies to: 43-43, 74-74, 91-91, 123-123, 187-187, 247-247

.github/workflows/secret-scanner.yml (1)

27-32: LGTM!

Also applies to: 41-46, 54-54

.github/workflows/instant-sync.yml (1)

21-21: LGTM!

.github/workflows/push-email-notify.yml (1)

43-43: LGTM!

.github/workflows/workflow-linter.yml (1)

21-21: LGTM!


📝 Summary

Summary by CodeRabbit

  • Security
    • Pinned third-party workflow actions to immutable versions, improving build and automation reproducibility.
    • Strengthened secret-scanning coverage by ensuring complete repository history is available in the relevant scan job.
  • Maintenance
    • Preserved existing workflow behaviour, configuration, and version references while improving supply-chain stability.

Walkthrough

The pull request replaces mutable GitHub Actions tags and branches with immutable commit SHAs across eight workflows. Previous version references remain as comments. The secret scanner also adds fetch-depth: 0 to the rust-secrets checkout.

Changes

Workflow action pinning

Layer / File(s) Summary
Pages and analysis workflow pins
.github/workflows/casket-pages.yml, .github/workflows/codeql.yml, .github/workflows/hypatia-scan.yml
Actions for Pages deployment, CodeQL, scanning, artifact upload, and scripting now use commit SHAs.
Validation workflow pins
.github/workflows/dogfood-gate.yml
Checkout and A2ML and K9 validation actions now use commit SHAs.
Secret scanner action pins
.github/workflows/secret-scanner.yml
Checkout, TruffleHog, and Gitleaks actions now use commit SHAs. The rust-secrets checkout adds fetch-depth: 0.
Notification and linter workflow pins
.github/workflows/instant-sync.yml, .github/workflows/push-email-notify.yml, .github/workflows/workflow-linter.yml
The repository dispatch, SMTP notification, and checkout actions now use commit SHAs.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Suggested reviewers: metadatastician

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: pinning third-party CI actions to full commit SHAs.
Description check ✅ Passed The description directly explains the Actions policy issue, the SHA pinning changes, the retained ref comments, and the explicit toolchain input. It is relevant to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks each action’s trail
Commit stones replace the tag-marked rail
Pages hop, scanners thump
No drifting refs make rabbits jump
The workflows pin their ears and sail

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath enabled auto-merge (squash) September 19, 2026 23:18
@hyperpolymath
hyperpolymath merged commit 0822c85 into main Sep 19, 2026
16 of 19 checks passed
@hyperpolymath
hyperpolymath deleted the fix/sha-pin-actions branch September 19, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant