Skip to content

chore(ci): remove dead Codecov upload steps + lock pins - #211

Merged
hyperpolymath merged 1 commit into
mainfrom
chore/remove-dead-app-ci-refs
Sep 20, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
chore/remove-dead-app-ci-refs

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Removed CI references to apps that are no longer installed on this account/org.

Why this is a fix, not a tidy-up

  • Codecov was uninstalled as a GitHub App, but its action steps remain in workflows.
  • The estate Actions allowlist already pruned codecov/codecov-action@* (standards/config/settings/actions-allowlist.json -> pruned_from_live_2026_09_02), so a workflow still calling it fails at job start instead of quietly no-op-ing.
  • Snyk / Codacy / Mergify / ImgBot / CodeFactor are on the estate never-re-add list (standards spec §9, rulings R1/R4/R5).

Changes

  • asdf-augmenters/asdf-acceleration-middleware/.github/workflows/ci.yml — applied
  • asdf-augmenters/asdf-acceleration-middleware/.github/workflows/rust-ci.yml — applied
  • rescript-ecosystem/packages/tooling/evangeliser/.github/workflows/ci.yml — applied
  • rescript-ecosystem/rescript-evangeliser/.github/workflows/ci.yml — applied

Notes

  • actions.lock entries for the removed actions are deleted in this same commit (the same-PR regen rule in the CI/CD regularisation spec §6.4), so actions-lock-verify sees no drift.
  • Removals are line-exact; no other line was reformatted and no comment was re-wrapped.
  • Historical records (milestone logs, CHANGELOG, audit docs, specs) that describe the removal were deliberately left untouched.
  • The gitar-approved label is intentionally frozen per docs/LABELS.adoc — it is not an active Gitar install, so it stays.

Line-exact removal of dead-app CI references.
@coderabbitai

coderabbitai Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: ad155fe9-3b2e-4992-b218-4a5b0343e261

📥 Commits

Reviewing files that changed from the base of the PR and between ba80ef4 and 0b4eb4b.

📒 Files selected for processing (4)
  • asdf-augmenters/asdf-acceleration-middleware/.github/workflows/ci.yml
  • asdf-augmenters/asdf-acceleration-middleware/.github/workflows/rust-ci.yml
  • rescript-ecosystem/packages/tooling/evangeliser/.github/workflows/ci.yml
  • rescript-ecosystem/rescript-evangeliser/.github/workflows/ci.yml
💤 Files with no reviewable changes (4)
  • asdf-augmenters/asdf-acceleration-middleware/.github/workflows/ci.yml
  • rescript-ecosystem/packages/tooling/evangeliser/.github/workflows/ci.yml
  • rescript-ecosystem/rescript-evangeliser/.github/workflows/ci.yml
  • asdf-augmenters/asdf-acceleration-middleware/.github/workflows/rust-ci.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Coverage reports continue to be generated during CI checks.
    • Automatic uploads of coverage results to Codecov have been removed from multiple workflows.

Walkthrough

Four CI workflows retain coverage generation but remove their Codecov upload steps. No public declarations change.

Changes

Coverage upload removal

Layer / File(s) Summary
Remove Codecov upload steps
.github/workflows/ci.yml, .github/workflows/rust-ci.yml
The Rust coverage workflows still generate Cobertura reports but no longer upload them to Codecov.
Remove JavaScript coverage upload steps
rescript-ecosystem/packages/tooling/evangeliser/.github/workflows/ci.yml, rescript-ecosystem/rescript-evangeliser/.github/workflows/ci.yml
The workflows still run coverage tests but no longer upload results to Codecov.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the removal of obsolete Codecov upload steps and lock entries from four CI workflows. It matches the stated changes and objectives.
Title check ✅ Passed The title clearly identifies the main change: removing dead Codecov upload steps and related lock pins from CI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the workflow run
Coverage grows beneath the sun
Codecov steps hop away
Reports still form and stay
The pipeline keeps its course today

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath merged commit 8440269 into main Sep 20, 2026
18 of 20 checks passed
@hyperpolymath
hyperpolymath deleted the chore/remove-dead-app-ci-refs branch September 20, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant