Skip to content

fix(ci): pin third-party actions to full commit SHAs - #85

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/sha-pin-actions
Sep 20, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
fix/sha-pin-actions

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

fix(ci): pin third-party actions to full commit SHAs

The account's Actions policy requires a full-length SHA ref. A tag or branch ref is refused at
startup — startup_failure, no jobs, "this workflow graph cannot be shown" — so these workflows
could not run at all. This resolves each ref to the commit it currently points at and records the
ref in a trailing comment, e.g. actions/checkout@<sha> # v4.

dtolnay/rust-toolchain takes its toolchain from the ref itself, so those steps also gained an
explicit with: toolchain: input; without it, a SHA ref would silently lose the channel.

No behaviour is intended to change beyond the pins.

The account's Actions policy requires a full-length SHA ref. A tag or branch ref is refused at
startup — `startup_failure`, no jobs, "this workflow graph cannot be shown" — so these workflows
could not run at all. This resolves each ref to the commit it currently points at and records the
ref in a trailing comment, e.g. `actions/checkout@<sha> # v4`.

`dtolnay/rust-toolchain` takes its toolchain from the ref itself, so those steps also gained an
explicit `with: toolchain:` input; without it, a SHA ref would silently lose the channel.

No behaviour is intended to change beyond the pins.
@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 80216c79-16fa-4881-a926-ab69d4c94c09

📥 Commits

Reviewing files that changed from the base of the PR and between 05368ad and b10c697.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (28)
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: governance / Actions lockfile verify
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: secret-scan / rust-secrets
  • GitHub Check: secret-scan / gitleaks
  • GitHub Check: scan / Hypatia Neurosymbolic Analysis
  • GitHub Check: secret-scan / shell-secrets
  • GitHub Check: rust-ci / Detect Cargo.toml
  • GitHub Check: Security Scan
  • GitHub Check: Test (3.10)
  • GitHub Check: Test (3.12)
  • GitHub Check: Test (3.11)
  • GitHub Check: Build Documentation
  • GitHub Check: analyze (javascript-typescript, none)
  • GitHub Check: check
  • GitHub Check: analyze (cpp, none)
  • GitHub Check: GitGuardian Security Checks
🔇 Additional comments (1)
.github/workflows/ci.yml (1)

84-86: LGTM!


📝 Summary

Summary by CodeRabbit

  • Chores
    • Improved build pipeline reliability by ensuring build tooling uses fixed, verified versions.
    • No changes to application functionality or the end-user experience.

Walkthrough

The CI build job now pins Docker actions to immutable commit SHAs. Existing version comments remain in place.

Changes

CI action pinning

Layer / File(s) Summary
Pin Docker build actions
.github/workflows/ci.yml
The build job replaces mutable version tags for docker/setup-buildx-action and docker/build-push-action with commit SHAs. It retains the v4 and v7 comments.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the CI policy requirement, the SHA pinning change, the dtolnay/rust-toolchain adjustment, and the intended lack of behavioural changes. However, it omits most template secti… Update the description to use the repository template. Complete the applicable Type of Change, Changes Made, Testing, Performance Impact, Breaking Changes, security, compliance, and checklist sections. Mark non-applicable sections as N/A an…
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: pinning third-party CI actions to full commit SHAs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the CI policy requirement, the SHA pinning change, the dtolnay/rust-toolchain adjustment, and the intended lack of behavioural changes. However, it omits most template sections, including Type of Change, Related Issues, Changes Made, Testing, Checklist, Performance Impact, Breaking Changes, and Reviewer Checklist.

Resolution

Update the description to use the repository template. Complete the applicable Type of Change, Changes Made, Testing, Performance Impact, Breaking Changes, security, compliance, and checklist sections. Mark non-applicable sections as N/A and include test commands and results where relevant.

  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the build
Two actions rest on fixed ground
Tags no longer drift
The workflow hops ahead
SHA-secure through the burrow

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit 1fac5b8 into main Sep 20, 2026
31 of 40 checks passed
@hyperpolymath
hyperpolymath deleted the fix/sha-pin-actions branch September 20, 2026 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant