Skip to content

docs: add Signed commits section to CONTRIBUTING - #115

Merged
hyperpolymath merged 1 commit into
mainfrom
docs/signing-policy-d218
Oct 1, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
docs/signing-policy-d218

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Adds a Signed commits section to this repo's CONTRIBUTING, per owner ruling D218. The estate policy is docs/SIGNING-POLICY.adoc in hyperpolymath/standards.

This repo's default branch is covered by the zero-bypass Require-Signed-Commits ruleset, and rebase-merge is off. The section tells contributors what that requires:

  • People and interactive agents sign with an SSH signing key.
  • Apps, bots and workflows write through the API, so GitHub signs their commits.
  • PRs are merged with squash.

If the file already had its own signing section, that section is replaced in place instead of adding a second one. Lines elsewhere that told people to sign with GPG are changed to match the policy (SSH for people).

This is a docs-only change. The commit was created through createCommitOnBranch, so GitHub signs it.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f

Owner ruling D218. See docs/SIGNING-POLICY.adoc in hyperpolymath/standards.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f
Copilot AI balanced review requested due to automatic review settings October 1, 2026 05:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: b4917854-7d73-445d-9075-dbf1525c089a

📥 Commits

Reviewing files that changed from the base of the PR and between fce9faa and 1b9ac4a.

📒 Files selected for processing (1)
  • CONTRIBUTING.adoc

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (37)
  • GitHub Check: governance / Actions lockfile verify
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: scan / gitleaks
  • GitHub Check: scan / rust-secrets
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: scan / shell-secrets
  • GitHub Check: build
  • GitHub Check: Groove manifest check
  • GitHub Check: TypeScript Tests (macos-latest)
  • GitHub Check: Validate K9 contracts
  • GitHub Check: TypeScript Tests (windows-latest)
  • GitHub Check: analyze (javascript-typescript, none)
  • GitHub Check: TypeScript Tests (ubuntu-latest)
  • GitHub Check: TypeScript Tests (macos-latest)
  • GitHub Check: RSR Compliance Check
  • GitHub Check: Rust Tests (macos-latest)
  • GitHub Check: Validate DEED manifests
  • GitHub Check: Rust Tests (ubuntu-latest)
  • GitHub Check: TypeScript Tests (windows-latest)
  • GitHub Check: TypeScript Tests (ubuntu-latest)
  • GitHub Check: Rust Tests (windows-latest)
  • GitHub Check: Empty-linter (invisible characters)
  • GitHub Check: security
  • GitHub Check: Security Audit
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
CONTRIBUTING.adoc (1)

113-114: 📐 Maintainability & Code Quality

The repository settings do not establish whether the ruleset targets main, has no bypass actors, or whether rebase merging is disabled. The concern remains undecidable because the API result returned null for those fields and for the ruleset’s conditions and rules.


📝 Summary

Summary by CodeRabbit

  • Documentation
    • Updated contribution guidance to require signed commits on the default branch, using a registered SSH signing key and verified committer email for people and interactive agents.
    • Clarified that apps, bots and workflows must use approved methods to create signed commits.
    • Documented that contributors must squash-merge; unsigned commits on pull request branches block merging, and rebase-merge is unavailable.

Walkthrough

CONTRIBUTING.adoc now requires signed commits, specifies signing and commit-writing methods for different contributor types, and requires squash merges.

Changes

Signed-commit policy

Layer / File(s) Summary
Signing and merge requirements
CONTRIBUTING.adoc
The guide requires signed commits, gives separate signing and commit-writing instructions for people and interactive agents versus apps, bots, and workflows, and requires squash merges. It states that unsigned commits block merging and that rebase-merge is disabled.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: metadatastician

Merge Risk: ⚪ Minimal · up to 1b9ac

The signing guidance introduces no established merge-blocking issue. This documentation-only change is ready to merge after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: adding a signed-commits section to CONTRIBUTING.
Description check ✅ Passed The description explains the signing policy and the related contributor instructions added to CONTRIBUTING.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks each commit’s mark,
Signed with care before the push.
Squash the branch, then hop along,
No unsigned hops will pass the gate.
The guide is clear; the burrow cheers,
And clover waits beyond the merge.

Comment @coderabbitai help to get the list of available commands.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

@hyperpolymath
hyperpolymath merged commit 605e14a into main Oct 1, 2026
38 of 48 checks passed
@hyperpolymath
hyperpolymath deleted the docs/signing-policy-d218 branch October 1, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants