Repository navigation
fix(ci): unbreak workflow YAML and add a complete actions.lock #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| # SPDX-License-Identifier: MPL-2.0 | ||
| # This workflow is managed by gh actions-lock. | ||
| # This workflow is managed by gh actions-lock. | ||
| permissions: | ||
| contents: read | ||
|
|
||
|
|
@@ -31,7 +32,7 @@ | |
| - uses: actions/checkout@v7.0.1 | ||
|
|
||
| - name: Install Rust | ||
| uses: dtolnay/rust-toolchain@4be9e76fd7c4901c61fb841f559994984270fce7 # stable | ||
| uses: dtolnay/rust-toolchain@v1 | ||
|
Check failure on line 35 in .github/workflows/ci.yml
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 HIGH RISK Pin this action to a full-length commit SHA to ensure immutability and protect against supply chain attacks. Replacing pinned SHAs with mutable tags (e.g., @v1) is a security regression and bypasses the protections of the actions-lock tool. This issue also occurs at lines 112, 157, 248, and 300. |
||
| with: | ||
| toolchain: ${{ matrix.rust }} | ||
| components: rustfmt, clippy | ||
|
|
@@ -108,7 +109,7 @@ | |
| - uses: actions/checkout@v7.0.1 | ||
|
|
||
| - name: Install Rust | ||
| uses: dtolnay/rust-toolchain@4be9e76fd7c4901c61fb841f559994984270fce7 # stable | ||
| uses: dtolnay/rust-toolchain@v1 | ||
|
Check failure on line 112 in .github/workflows/ci.yml
|
||
| with: | ||
| targets: wasm32-unknown-unknown | ||
|
|
||
|
|
@@ -153,7 +154,7 @@ | |
| - uses: actions/checkout@v7.0.1 | ||
|
|
||
| - name: Install Rust | ||
| uses: dtolnay/rust-toolchain@4be9e76fd7c4901c61fb841f559994984270fce7 # stable | ||
| uses: dtolnay/rust-toolchain@v1 | ||
|
Check failure on line 157 in .github/workflows/ci.yml
|
||
|
|
||
| - name: Cargo Audit | ||
| working-directory: rust_core | ||
|
|
@@ -244,7 +245,7 @@ | |
| - uses: actions/checkout@v7.0.1 | ||
|
|
||
| - name: Install Rust | ||
| uses: dtolnay/rust-toolchain@4be9e76fd7c4901c61fb841f559994984270fce7 # stable | ||
| uses: dtolnay/rust-toolchain@v1 | ||
|
Check failure on line 248 in .github/workflows/ci.yml
|
||
| with: | ||
| targets: wasm32-unknown-unknown | ||
|
|
||
|
|
@@ -296,7 +297,7 @@ | |
| - uses: actions/checkout@v7.0.1 | ||
|
|
||
| - name: Install Rust | ||
| uses: dtolnay/rust-toolchain@4be9e76fd7c4901c61fb841f559994984270fce7 # stable | ||
| uses: dtolnay/rust-toolchain@v1 | ||
|
Check failure on line 300 in .github/workflows/ci.yml
|
||
| with: | ||
| components: llvm-tools-preview | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| # SPDX-License-Identifier: MPL-2.0 | ||
| # This workflow is managed by gh actions-lock. | ||
| # This workflow is managed by gh actions-lock. | ||
| # Dormant push-email notification. ARMED by setting the repo variable | ||
| # PUSH_EMAIL_ENABLED=true (the single on/off switch). Addresses are pre-filled; | ||
| # sending needs the org SMTP secrets (SMTP_HOST/PORT/USER/PASS). Inherited by | ||
|
|
@@ -16,7 +17,7 @@ | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Send push notification email | ||
| uses: dawidd6/action-send-mail@v18 | ||
| uses: dawidd6/action-send-mail@v3.12.0 | ||
|
Check failure on line 20 in .github/workflows/push-email-notify.yml
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 HIGH RISK Pin the dawidd6/action-send-mail action to a full-length commit SHA. Using a version tag like @v3.12.0 is mutable and exposes the CI environment to potential upstream changes. |
||
| with: | ||
| server_address: ${{ secrets.SMTP_HOST }} | ||
| server_port: ${{ secrets.SMTP_PORT }} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚪ LOW RISK
Nitpick: Redundant duplicate comment: '# This workflow is managed by gh actions-lock.' already exists on line 2. Please remove the duplicate on line 3.