Repository navigation
chore(playground): remove un-instantiated ffi/zig template subtree - #331
Merged
Merged
Conversation
The subtree still contains literal {{project}}/{{PROJECT}} scaffold
placeholders and cannot compile. Nothing in the playground references
it, and the real Zig FFI lives at ffi/zig/ and src/zig_ffi/. Follows
the docs/PROOF-NEEDS.md precedent of removing un-instantiated template
scaffolding rather than letting it masquerade as implementation.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Code Review ✅ ApprovedRemoves the un-instantiated ffi/zig template subtree from the playground since it contains literal placeholders and is entirely unreferenced. No issues found.
OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
echidna-playground/ffi/zig/is un-instantiated scaffolding: it still contains literal{{project}}/{{PROJECT}}placeholders, so it cannot compile. Nothing in the playground references it, and the real Zig FFI lives atffi/zig/andsrc/zig_ffi/.This follows the repo's own precedent in
docs/PROOF-NEEDS.md, where un-instantiated template scaffolding was removed rather than left to masquerade as implementation.Verified: a reference sweep across the playground's JSON, ReScript, Forth, AsciiDoc, Markdown and HTML files finds no mention of the removed subtree.