ci(rhodibot): switch to the report-only canary (standards#759) - #156
Conversation
The RSR workflow here is the mutating variant: weekly cron, write permissions,
glob deletes, a bulk SPDX `sed` sweep the licence policy forbids, a
`${{ steps.fix.outputs.FIXES }}` injection sink, and a hardcoded personal
e-mail. Replaced with the canary the template ships: same schedule, same drift
signal, reports instead of mutating.
Refs hyperpolymath/standards#759 (option (a), canary propagation).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (35)
🧰 Additional context used🪛 zizmor (1.30.0).github/workflows/rhodibot.yml[warning] 36-39: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false (artipacked) [error] 37-37: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy) (unpinned-uses) [info] 32-32: workflow or action definition without a name (anonymous-definition): this job (anonymous-definition) 🔇 Additional comments (1)
📝 SummarySummary by CodeRabbit
WalkthroughThe workflow now runs a read-only RSR compliance canary. It detects repository drift, reports findings, and fails when required conditions are missing or would require mutation. It no longer edits files, creates branches, or opens pull requests. ChangesRSR compliance canary
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the files at dawn Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
The RSR workflow in this repository is the mutating variant of rhodibot: it runs on a
weekly cron with
contents: write+pull-requests: write, deletes files by glob, andbulk-rewrites SPDX headers — which the standing licence policy forbids. It also interpolates
${{ steps.fix.outputs.FIXES }}into arun:block (repo-derived filenames, soattacker-influenceable) and hardcodes a personal e-mail address.
This replaces it with the report-only canary that the estate template already ships — the
already-approved design, not a new one. Same weekly schedule, same drift signal, no mutation:
it reports what an auto-fixer would have changed and fails the run when it finds drift,
rather than editing anything. Licence/SPDX drift is reported for manual, owner-only
correction; rhodibot must never edit a licence header.
Part of the
standards#759migration (canary propagation, option (a)). The workflow'suses:pins are unchanged, so
actions.lockis unaffected.