Skip to content

docs: add Signed commits section to CONTRIBUTING - #165

Merged
hyperpolymath merged 1 commit into
mainfrom
docs/signing-policy-d218
Oct 1, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
docs/signing-policy-d218

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Adds a Signed commits section to this repo's CONTRIBUTING, per owner ruling D218. The estate policy is docs/SIGNING-POLICY.adoc in hyperpolymath/standards.

This repo's default branch is covered by the zero-bypass Require-Signed-Commits ruleset, and rebase-merge is off. The section tells contributors what that requires:

  • People and interactive agents sign with an SSH signing key.
  • Apps, bots and workflows write through the API, so GitHub signs their commits.
  • PRs are merged with squash.

If the file already had its own signing section, that section is replaced in place instead of adding a second one. Lines elsewhere that told people to sign with GPG are changed to match the policy (SSH for people).

This is a docs-only change. The commit was created through createCommitOnBranch, so GitHub signs it.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f

Owner ruling D218. See docs/SIGNING-POLICY.adoc in hyperpolymath/standards.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f
Copilot AI balanced review requested due to automatic review settings October 1, 2026 05:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 9ee654cc-e6a4-4d5b-9a25-f8dfe3b8dd0e

📥 Commits

Reviewing files that changed from the base of the PR and between dbeee8a and 1c10b3f.

📒 Files selected for processing (1)
  • CONTRIBUTING.adoc

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (32)
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Actions lockfile verify
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: scan / gitleaks
  • GitHub Check: scan / rust-secrets
  • GitHub Check: scan / shell-secrets
  • GitHub Check: analyze / analyze
  • GitHub Check: rust-ci / Detect Cargo.toml
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: Validate eclexiaiser manifest
  • GitHub Check: E2E — Unit, P2P and End-to-End
  • GitHub Check: Empty-linter (invisible characters)
  • GitHub Check: Validate K9 contracts
  • GitHub Check: Groove manifest check
  • GitHub Check: Validate DEED manifests
  • GitHub Check: Proof protocol contracts
  • GitHub Check: Hypatia neurosymbolic scan
  • GitHub Check: panic-attack assail
  • GitHub Check: openssf-compliance
  • GitHub Check: Patch Bridge CVE triage
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (3)
CONTRIBUTING.adoc (3)

160-165: LGTM!

Also applies to: 166-167, 187-187


156-157: 🔒 Security & Privacy | 🛡️ Detected with Advanced Tier

The signature-enforcement statement is supported by active default-branch rulesets. Require-Signed-Commits and default-branch-protection both apply required_signatures to ~DEFAULT_BRANCH. The optional API call in scripts/governance/apply-branch-protection.sh does not contradict these rulesets.

Likely an incorrect or invalid review comment.


169-169: 🔒 Security & Privacy | 🛡️ Detected with Advanced Tier

Check the repository's rebase-merge setting. The branch-protection script does not set allow_rebase_merge, and the available API access returns null for this field. Confirm with repository-admin access that rebase merging is disabled. If it is enabled, disable it because rebase merging can add rewritten unsigned commits to the default branch.


📝 Summary

Summary by CodeRabbit

  • Documentation
    • Updated contribution guidance to cover commit signing requirements, signing methods, and the use of squash merges.
    • Changed the pull request checklist to ask for signed commits rather than specifically GPG-signed commits.

Walkthrough

The contribution guide now describes commit-signing requirements, supported signing methods, and merge rules. The pull request checklist now requires signed commits rather than GPG-signed commits.

Changes

Contribution guidance

Layer / File(s) Summary
Commit-signing guidance and checklist
CONTRIBUTING.adoc
The guide requires signed commits to the default branch under a ruleset. It describes SSH signing for people and interactive agents, API-based commits for apps, bots and workflows, and squash merges. It also states that unsigned commits on the pull request branch block merging and that rebase-merge is disabled. The checklist now requires signed commits.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 1c10b

The updated signing guidance is mergeable with normal checks. No concrete workflow regression was established, although the stated squash and rebase settings could not be independently confirmed.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 1c10b

This changes contribution instructions, not enforcement. No introduced security weakness was established, but the stated merge restrictions could not be fully checked against active repository settings.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The assessed boundary is contribution admission to this repository's default branch. The documentation change does not demonstrate additional credential authority, cross-repository access, deployment access, or a broader attacker-controlled execution path.

Security Findings and Attack Paths

  • observed — The supplied security assessment retains no findings. The disabled-rebase candidate remains deferred because the active allow_rebase_merge value is unavailable; that uncertainty does not establish an exploitable bypass or a regression introduced by this PR.

Trust Boundaries and Controls

  • observed — Supplied verification reports active default-branch rulesets requiring signed commits and rejects the corresponding missing-enforcement candidate. This is counterevidence to a signing-enforcement gap, but does not independently verify every documented merge restriction or bypass setting.

Resilience and Maintainability Implications

  • observed — The existing script continues after a failed required-signatures POST and prints a completion message. This pre-existing recovery behavior cannot establish successful signature enforcement by that script, but it neither proves an active ruleset failure nor constitutes an introduced PR concern.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the documentation change and names the affected file.
Description check ✅ Passed The description directly explains the signed-commit guidance added to CONTRIBUTING and matches the documented changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks each commit's mark,
Then hops through rules from dawn till dark.
SSH keys shine, APIs pass,
Squash merges keep the branch in class.
The checklist blooms; the hare says, “Done!”

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath merged commit f4ff375 into main Oct 1, 2026
40 of 47 checks passed
@hyperpolymath
hyperpolymath deleted the docs/signing-policy-d218 branch October 1, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants