Skip to content

ci(secret-scan): rename caller job key secret-scan -> scan (D243) - #63

Merged
hyperpolymath merged 1 commit into
mainfrom
ci/secret-scan-floor-key
Oct 1, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
ci/secret-scan-floor-key

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

What

Rename the secret-scanner caller job key secret-scan → scan in .github/workflows/secret-scanner.yml, so the check context becomes scan / gitleaks — the context the estate Secret-Scan-Floor ruleset (D243/D244) requires. One-line change; reusable pin, triggers and permissions unchanged. actionlint output is identical before and after.

Commit created via GraphQL createCommitOnBranch (GitHub-signed, signature valid: true).

🤖 Generated with Claude Code

https://claude.ai/code/session_0136eszqrQ53Kj7aBH1D4rXK

Secret-Scan-Floor (D243/D244) requires the context `scan / gitleaks` estate-wide. The caller job key here was `secret-scan`, which emits `secret-scan / gitleaks` and can never satisfy the floor. Rename only; the reusable pin and permissions are unchanged.

actionlint output identical before and after.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136eszqrQ53Kj7aBH1D4rXK
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: d506898d-2959-4647-a25b-02e0e360cb52

📥 Commits

Reviewing files that changed from the base of the PR and between 6ef5fce and 86e5263.

📒 Files selected for processing (1)
  • .github/workflows/secret-scanner.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (6)
  • GitHub Check: scan / gitleaks
  • GitHub Check: scan / rust-secrets
  • GitHub Check: scan / shell-secrets
  • GitHub Check: Hypatia Neurosymbolic Analysis
  • GitHub Check: Type-check .affine sources
  • GitHub Check: CodeQL Analysis (javascript-typescript)
🔇 Additional comments (1)
.github/workflows/secret-scanner.yml (1)

18-18: LGTM!


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated the automated security scanning workflow. This internal change does not affect application features or the experience of using the product.

Walkthrough

The secret-scanner workflow job was renamed from secret-scan to scan. The reusable workflow and inherited secrets are unchanged.

Changes

Secret scanner workflow

Layer / File(s) Summary
Rename the workflow job
.github/workflows/secret-scanner.yml
The job name changed from secret-scan to scan. The reusable workflow and inherited secrets are unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 86e52

The rename targets the required scan / gitleaks check context, and no workflow dependency on the old job key remains. No specific merge-blocking risk is identified.

Architecture Summary

Architecture risk: 🔵 Low · up to 86e52

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/secret-scanner.yml: Renamed the job from secret-scan to scan; its reusable workflow and inherited secrets are unchanged.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: renaming the CI secret-scan caller job key from secret-scan to scan.
Description check ✅ Passed The description directly explains the job-key rename, the required check context, and the unchanged workflow behaviour. It is relevant to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the scanner's name,
scan now joins the workflow game.
The secrets stay as they were,
The reused flow stays sure.
I twitch my nose and hop away.

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath merged commit 4b9cddb into main Oct 1, 2026
11 of 12 checks passed
@hyperpolymath
hyperpolymath deleted the ci/secret-scan-floor-key branch October 1, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant