ci: relay test failures as annotations (diagnose the red cell) - #111
Merged
Merged
Conversation
arena-ai-coding-agent
Bot
requested a review
from hyperpolymath
as a code owner
September 29, 2026 17:08
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
arena-ai-coding-agent
Bot
force-pushed
the
arena/01a0edde-feedback-o-tron
branch
from
September 29, 2026 17:09
d7db9d8 to
6f64a6a
Compare
arena-ai-coding-agent
Bot
deleted the
arena/01a0edde-feedback-o-tron
branch
September 29, 2026 17:10
hyperpolymath
added a commit
that referenced
this pull request
Sep 29, 2026
…n) (#112) main is currently red: all three Elixir cells fail on exactly one test, `run/2 confirm gate a yes with the consent service down sends nothing and exits non-zero`. Why PR #111 was needed first: log archives live on `results-receiver.actions.githubusercontent.com`, which the sandbox cannot reach, so the failure could not be read the way a human would. That PR (already merged) re-emits the failing block as a check annotation. The diagnosis from `mix test` exit code 2: that is not a plain assertion failure — it is the branch where an exception escapes the suite, and the only candidate here is the `on_exit` that restores the consent service's registered name. It is now best-effort and cannot raise. The assertions also name the values they compare, so if this still fails the next run says *which* of the two behaviours is wrong rather than only which test. No behaviour changed; nothing but the test moved. --------- Co-authored-by: Arena Agent <agent@arena.ai> Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com> Co-authored-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #110 merged and CI ran for real on
main. Result:Compile (warnings as errors)— green on all three cellsDialyzer— greenRun tests— red on all three cells, one failure:test run/2 confirm gate a yes with the consent service down sends nothing and exits non-zero (FeedbackATron.CLITest)Exit code 2 means failures and compile warnings, so there are two things to read.
This PR adds the relay so the failure is readable at all: log archives are hosted on
results-receiver.actions.githubusercontent.com, which is not reachable from the sandbox, so a red cell cannot be diagnosed from the log the way a human would. The step re-emits the failing block (and the compile warnings) as a check annotation, which the Checks API exposes.No behaviour is changed by this PR. Next: read the annotation, fix the test, then decide whether the relay stays.