Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions TEST-NEEDS.adoc
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
== Test & Benchmark Requirements

[NOTE]
====
SUPERSEDED 2026-09-15. This audit predates PR #93 — the engine now has 318
passing tests, so "Unit tests: NONE (0 test files found)" below is false — and
predates the FOT-R-22 retire, which deleted the nine migration-observer,
batch-reviewer, report-generator and GenStage-pipeline modules still named in
the file list below. Re-run the audit before acting on any figure here.

VeriSimDB itself is NOT retired: it remains a live estate integration
(`.machine_readable/integrations/verisimdb.a2ml`, gated by `dogfood-gate.yml`).
Only the two FoT-internal writers went with the pipeline.
====

=== CRG Grade: C — ACHIEVED 2026-04-04

=== Current State
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,10 @@ Elixir 1.19 / OTP 27._
question, not a build. This is the core and it stays the core.
* A GenStage migration-observation pipeline (producer → review consumer →
VeriSim writer) with a batch reviewer and report generator, built for the
ReScript migration. Real and tested, narrow in purpose, and the natural
seed for burst clustering at L5.
ReScript migration. RETIRED 2026-09-15 by owner ruling FOT-R-22: it was never
wired into the supervision tree, carried zero tests despite the claim above,
and the ReScript migration it was built for is moot under the bun-only
doctrine. Do not seed L5 burst clustering on it — it no longer exists.
* The MCP server (`mcp/server.ex`, stdio by default, optional loopback TCP)
exposing three tools: research, synthesize, submit.
* The HTTP intake (`http_intake/router.ex`, 127.0.0.1:7722, off by default)
Expand Down
36 changes: 1 addition & 35 deletions elixir-mcp/lib/feedback_a_tron/application.ex
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ defmodule FeedbackATron.Application do
- NetworkVerifier: Pre-flight network checks
- Doors: MCP stdio server and HTTP intake, opened by `FeedbackATron.Doors`
from the `:doors` application env or the `FEEDBACK_O_TRON_*` environment
- MigrationObserver: ReScript migration session tracking (optional)
- BatchReviewer: Issue review queue (optional, with migration observer)
- Pipeline.Supervisor: GenStage pipeline (optional, with migration observer)
"""

use Application
Expand All @@ -27,10 +24,7 @@ defmodule FeedbackATron.Application do
System.get_env()
)

children =
core_children() ++
FeedbackATron.Doors.children(doors) ++
migration_observer_children()
children = core_children() ++ FeedbackATron.Doors.children(doors)

opts = [strategy: :one_for_one, name: FeedbackATron.Supervisor]
Supervisor.start_link(children, opts)
Expand All @@ -47,32 +41,4 @@ defmodule FeedbackATron.Application do
{FeedbackATron.NetworkVerifier, enabled: true}
]
end

defp migration_observer_children do
if migration_observer_enabled?() do
[
FeedbackATron.MigrationObserver,
FeedbackATron.BatchReviewer,
FeedbackATron.Pipeline.Supervisor
]
else
[]
end
end

defp migration_observer_enabled? do
env_val = System.get_env("FEEDBACK_A_TRON_MIGRATION_MODE")

env_on? =
case env_val do
nil ->
false

value ->
normalized = value |> String.trim() |> String.downcase()
Enum.member?(["1", "true", "yes", "on"], normalized)
end

env_on? || Enum.any?(System.argv(), &(&1 == "--migration-observer"))
end
end
222 changes: 0 additions & 222 deletions elixir-mcp/lib/feedback_a_tron/batch_reviewer.ex

This file was deleted.

Loading
Loading