Skip to content

fix(ci): repair the permissions block indentation (invalid YAML) - #89

Merged
hyperpolymath merged 2 commits into
mainfrom
fix/ci-permissions-indentation
Sep 21, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
fix/ci-permissions-indentation

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

The permissions: block added by the caller-permission campaign was indented one level too deep (appended at job-child indent + 2), which makes the whole workflow file invalid YAML (mapping values are not allowed here) and stops the workflow loading at all. This dedents the block to job-key level — keeping the grants — and validates the file parses before committing.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 4920fd1f-49a1-4c24-a7ae-eca5502cd897

📥 Commits

Reviewing files that changed from the base of the PR and between 686766c and 7ba646c.

📒 Files selected for processing (2)
  • .github/workflows/governance.yml
  • .github/workflows/secret-scanner.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (30)
  • GitHub Check: governance / Actions lockfile verify
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: scan / gitleaks
  • GitHub Check: scan / shell-secrets
  • GitHub Check: scan / rust-secrets
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: Empty-linter (invisible characters)
  • GitHub Check: panic-attack assail
  • GitHub Check: Hypatia neurosymbolic scan
  • GitHub Check: Validate eclexiaiser manifest
  • GitHub Check: Patch Bridge CVE triage
  • GitHub Check: Groove manifest check
  • GitHub Check: Validate A2ML manifests
  • GitHub Check: Validate K9 contracts
  • GitHub Check: analyze (actions, none)
  • GitHub Check: Workflow and session contract validation
  • GitHub Check: openssf-compliance
  • GitHub Check: estate-audit
🔇 Additional comments (2)
.github/workflows/governance.yml (1)

19-22: LGTM!

.github/workflows/secret-scanner.yml (1)

25-28: LGTM!


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated governance and secret-scanning workflow permission declarations.
    • Permissions now apply at the appropriate job level while retaining read access to actions and contents, plus security-event write access.
    • No end-user functionality or public interfaces have changed.

Walkthrough

The governance and scan reusable workflow jobs now declare their existing permissions at job level.

Changes

Reusable workflow permissions

Layer / File(s) Summary
Job-level reusable workflow permissions
.github/workflows/governance.yml, .github/workflows/secret-scanner.yml
The governance and scan jobs declare actions: read, contents: read, and security-events: write at job level.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: correcting invalid YAML caused by incorrect permissions block indentation in CI workflows.
Description check ✅ Passed The description explains the cause, impact, fix, preserved permissions, and validation. It does not use the repository template headings or include the checklist, but it contains the critical informat…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the workflow gate
Permissions sit at the proper state
Governance reads, scanners scan
Each job follows the YAML plan
The burrow runs on schedule neat

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit 927f3b5 into main Sep 21, 2026
30 of 34 checks passed
@hyperpolymath
hyperpolymath deleted the fix/ci-permissions-indentation branch September 21, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant