Skip to content

Generate credential test values at runtime - #531

Closed
coderabbitai[bot] wants to merge 10 commits into
mainfrom
coderabbit/remove-secret-like-test-value/b7745e3f
Closed

coderabbitai[bot] wants to merge 10 commits into
mainfrom
coderabbit/remove-secret-like-test-value/b7745e3f

Conversation

@coderabbitai

@coderabbitai coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Replace secret-like hardcoded password fixtures in Cipherbot infrastructure analyzer tests with dynamically generated values, preserving credential detection and non-infrastructure filtering coverage while avoiding security scanner failures. Validation was not run.

View coding task

hyperpolymath and others added 10 commits August 27, 2026 14:22
MEASURED 2026-08-27: this gate's pattern caught 0 OF 6 invisible-character test
cases. It has never detected an NBSP, zero-width space, BOM, soft hyphen, bidi
override or word joiner.

ROOT CAUSE: the pattern used UTF-8 BYTE sequences (\xc2\xa0) while grep -P
matches CHARACTERS. Bytes c2 a0 are ONE character U+00A0; \xc2\xa0 asks for TWO
characters, U+00C2 then U+00A0, which is never present.

  grep -P '\xc2\xa0'  ->  miss
  grep -P '\x{a0}'    ->  MATCH

Only \x00 worked, being single-byte in both readings.

FIXED: codepoint escapes; C0 control characters \x01-\x08,\x0B,\x0C,\x0E-\x1F
added (TAB/LF/CR excluded); and grep -a, without which grep skips any NUL-bearing
file as binary.

The C0 range matters: a stray BACKSPACE byte made a workflow unparseable in
developer-ecosystem, so it never ran, and this linter called it clean.

Canonical fix: hyperpolymath/empty-linter#70. 1 file(s) here.
VERIFIED: YAML re-parsed, and the corrected pattern was confirmed to catch a real
NBSP before the change was kept.
Co-authored-by: codacy-production[bot] <61871480+codacy-production[bot]@users.noreply.github.com>
Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
… governance workflows (#513)

CI failure fixes was requested by @hyperpolymath.

*
#497 (comment)

The following files were modified:

* `bots/seambot/tests/github_integration.rs`
* `dashboard/src/main.rs`
* `robot-repo-automaton/src/fixer.rs`

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Base automatically changed from fix/empty-linter-pattern-never-matched to main September 15, 2026 15:12
@gitguardian

gitguardian Bot commented Sep 15, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
36740420 Triggered Generic Password 19a7545 bots/cipherbot/src/analyzers/infra.rs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@hyperpolymath

Copy link
Copy Markdown
Owner

Closing as stale and near-duplicate.

Evidence:

Re-run the task against current main if any cipherbot-side fixture work from this branch is still missing there.

auto-merge was automatically disabled September 17, 2026 10:14

Pull request was closed

@hyperpolymath
hyperpolymath deleted the coderabbit/remove-secret-like-test-value/b7745e3f branch September 18, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant