fix(rsr): make the estate census trustworthy - #537
Merged
Merged
Conversation
Two defects found by running the freshly-merged census against the live estate. Both made the detector confidently wrong, which is worse than silent: * Blob-only listing. `.machine_readable/bot_directives` is a *directory*, so a blob-only census could never match it and the check was reported DEAD (0/262) when the true figure is 137/262. Trees are now emitted alongside blobs. * Stale tip. The census resolved the branch through /commits/HEAD, which is cacheable and observably lags. Immediately after squash-merging JuliaForChildren.jl, /commits/HEAD still reported the pre-merge commit (bfcd9683) while /git/refs/heads/main, /branches/main and git ls-remote all agreed on the real tip (1511c8a0). The census therefore described a repository that no longer existed in that state. The tip is now resolved through /git/refs/heads/<branch>, which is authoritative. Verified after the fix: census for JuliaForChildren.jl shows root .well-known/ absent and www/.well-known/ present, matching main. Detector over 262 repositories reports www/.well-known/security.txt at 248/262 and no false DEAD.
Contributor
|
Warning Review limit reachedNext included review available in 53 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two defects found by running the just-merged census against the live estate, both of which made the detector confidently wrong.
.machine_readable/bot_directivesis a directory, so it could never match and was reported DEAD (0/262) against a true figure of 137/262./commits/HEADis cacheable and lags. After the JuliaForChildren.jl merge it still reported the pre-merge commit (bfcd9683) while/git/refs/heads/main,/branches/mainandgit ls-remoteall agreed on1511c8a0.Both are documented in the commit message with the observed evidence.