Skip to content

Fail supervised scans on incomplete coverage #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 1 commit into from
Sep 27, 2026
Merged

Fail supervised scans on incomplete coverage #573

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions fleet-coordinator.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,11 +155,18 @@ scan_supervised_repos() {
fi

local -a repo_paths
mapfile -t repo_paths < <("$list_script" "${args[@]}")
local resolved_repos
if ! resolved_repos=$("$list_script" "${args[@]}"); then
log_error "Failed to resolve supervised repository inventory"
return 1
fi
if [[ -n "$resolved_repos" ]]; then
mapfile -t repo_paths <<< "$resolved_repos"
fi

if [[ "${#repo_paths[@]}" -eq 0 ]]; then
log_warn "No supervised repositories resolved"
return 0
log_error "No supervised repositories resolved; refusing a false-green scan"
return 1
fi

log_info "Scanning ${#repo_paths[@]} supervised repos"
Expand All @@ -176,6 +183,11 @@ scan_supervised_repos() {

log_info "Supervised scan complete: scanned=$scanned failed=$failed"

if [[ "$failed" -gt 0 ]]; then
log_error "Supervised scan incomplete: $failed of ${#repo_paths[@]} repositories failed"
return 1
fi

if [[ "$process_after" == true ]]; then
process_findings
fi
Expand Down
Loading